showShareSheet causes app crash about cordova-ionic-phonegap-branch-deep-linking-attribution HOT 9 CLOSED

@GrahenKraken ,
Let me try to replicate the issue. At the moment, can you provide additional details for your setup?
eg: Cordova, Android, and plugin versions.

Thanks

from cordova-ionic-phonegap-branch-deep-linking-attribution.

I produced the issue on the testbed app on a Nexus 5 device. Standard
setup, just built it and used the "show share sheet" button, and got "The
app has stoppes working". I can provide more detailed information tomorrow,
since I won't be awake much longer :)
On 14 Apr 2016 1:55 am, "Renemari Padillo" [email protected] wrote:

@GrahenKraken https://github.com/GrahenKraken ,
Let me try to replicate the issue. At the moment, can you provide
additional details for your setup?
eg: Cordova, Android, and plugin versions.

Thanks

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#102 (comment)

from cordova-ionic-phonegap-branch-deep-linking-attribution.

okay thanks, that would do.
At the moment I'll try to reproduce the bug and give you feedback on my findings and its fix.

from cordova-ionic-phonegap-branch-deep-linking-attribution.

Hi @GrahenKraken ,
I don't have a Nexus 5 device, so I used Samsung S4 instead.
However I've been trying to resolve the issue but somehow I can't find a way to replicate the error.
Does this only happen on a specific device?
I've tried also testing with ASUS Zenfone and still it doesn't have any error.

from cordova-ionic-phonegap-branch-deep-linking-attribution.

Hi @renesansz , thanks for the speedy responses.
I am currently running your testbed app.
My Cordova version is 6.1.1, I am running it on a Samsung Galaxy Grand Prime (SM-G531H) with Android 5.1.1. The plugin is the latest version from this repo, which seems to be 2.0.9 (downloaded again yesterday to make sure it's fresh)

I start up the testbed app, get the initial alerts, click "Init Branch Universal Object", get those alerts.
Then I click "Share Sheet", select "Show More", then select Hangouts as an option, the list slides down, and the crash happens just before I get to choose my Hangouts account, with the "Choose Account" dialog behind the error "alert". It happens every couple of times. If it doesn't, I just go back (without selecting a Hangouts account) and retry until it crashes.

from cordova-ionic-phonegap-branch-deep-linking-attribution.

@GrahenKraken ,
I see, so far I don't know the reason why it happens sometimes.
Let me investigate further on what's causing this error.

from cordova-ionic-phonegap-branch-deep-linking-attribution.

Hi @GrahenKraken ,
On the nth time, I wasn't able to reproduce the error.
So what I did was to re-inspect the error log that you've produced and it stated

E/AndroidRuntime( 4357): java.lang.RuntimeException: Unable to pause activity {com.selfikon.anna/com.selfikon.anna.MainActivity}: android.view.ViewRootImpl$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views.

It was mentioned before in regards to threading on this discussion.
So in the PR #105 I implemented it on the plugin, let me know if this will resolve the issue that you are having.

Cheers,
Rene

from cordova-ionic-phonegap-branch-deep-linking-attribution.

Hey @renesansz ,

#105 resolved the issue, and from looking at the changes, it is exactly what was needed :)

However, now the "Facebook" option on the shareSheet seems broken:

Selecting the option opens up a blank screen for a few seconds and closes with no callback in JS.
P.S. Not sure if I should open up a new issue for this?

from cordova-ionic-phonegap-branch-deep-linking-attribution.

@GrahenKraken ,
Glad to hear that fix works for you.
Yes, please open up another issue for this and provide the logs & how the error occurs.

Closing PR.

Cheers,
Rene

from cordova-ionic-phonegap-branch-deep-linking-attribution.