Giter VIP home page Giter VIP logo

Comments (3)

aaustin avatar aaustin commented on July 17, 2024

@aquach - Can you try the latest plugin? We've revamped this module entirely to a much more updated and stable version. This should be resolved.

from cordova-ionic-phonegap-branch-deep-linking-attribution.

aquach avatar aquach commented on July 17, 2024

The new Android app still uses eval via the sendJavascript method. See BranchSDK.java:808:

webView.sendJavascript(out);

which evaluates to a eval on the JS side of Cordova. Best practices are to use registered callbacks rather than arbitrarily evaluation of Javascript, which we block with our Content Security Policy.

from cordova-ionic-phonegap-branch-deep-linking-attribution.

renesansz avatar renesansz commented on July 17, 2024

@aquach ,
The reason why we used sendJavascript to execute the callback method in JS is to compensate with iOS' implementation with DeepLinkHandler call.
At the moment, upon triggering the initSession in iOS DeepLinkHandler could not determine which callback is registered. So instead evalJS is used to execute the callback. See line 134

But we are looking on alternative solution in order to fix this issue.
We'll let you know what we find.

from cordova-ionic-phonegap-branch-deep-linking-attribution.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.