Comments (3)
@aquach - Can you try the latest plugin? We've revamped this module entirely to a much more updated and stable version. This should be resolved.
from cordova-ionic-phonegap-branch-deep-linking-attribution.
The new Android app still uses eval via the sendJavascript
method. See BranchSDK.java:808:
webView.sendJavascript(out);
which evaluates to a eval
on the JS side of Cordova. Best practices are to use registered callbacks rather than arbitrarily evaluation of Javascript, which we block with our Content Security Policy.
from cordova-ionic-phonegap-branch-deep-linking-attribution.
@aquach ,
The reason why we used sendJavascript
to execute the callback method in JS is to compensate with iOS' implementation with DeepLinkHandler
call.
At the moment, upon triggering the initSession in iOS DeepLinkHandler
could not determine which callback is registered. So instead evalJS
is used to execute the callback. See line 134
But we are looking on alternative solution in order to fix this issue.
We'll let you know what we find.
from cordova-ionic-phonegap-branch-deep-linking-attribution.
Related Issues (20)
- "module 'AdServices' not found" on build_ios Fastlane HOT 2
- Apple Search Ads has data on Dashboard but no Keyword / Campaign attribution HOT 1
- iOS 15 Support HOT 2
- Android app crashes on launch
- Why referencing a window object `Branch = window['Branch']` and not injecting through dependency injection?
- Android 12 requires app links verification similar to iOS AASA HOT 3
- request package critical vulnerability HOT 5
- Allow us to specify android-prefix for non-bnc.lt link domains
- Prototype pollution in plist HOT 6
- BranchIo is not injectable HOT 1
- disableTracking() / initSession() error on subsequent calls HOT 4
- "Cordova is not available" when running on simulator/device HOT 1
- How can I get "campaign name" from traffic source? HOT 1
- Can Branch.io fallback to a different app HOT 1
- bug: iOS crashes with registerView and generateShortUrl HOT 3
- Missing header files in Xcode HOT 2
- Latest SDK Updates fail to compile Android HOT 2
- Latest SDK Updates fail to compile on IOS HOT 4
- Not working with [email protected] HOT 2
- Deeplink not working when tracking be disabled on Android HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cordova-ionic-phonegap-branch-deep-linking-attribution.