Bunch of iOS (+1 java) plugin issues that still need to be addressed about cordova-ionic-phonegap-branch-deep-linking-attribution HOT 6 CLOSED

@pragunvohra ,
Thanks for the report, however I think I'll be needing my colleague here to fix the issues for iOS.

In regards to userCompletedAction (Android). I think this should be fixed first on the Android SDK itself, since there is no other way to resolve the promise being returned to early.
I'll consult first to the other developers for this plugin, if they have solution for this issue.

from cordova-ionic-phonegap-branch-deep-linking-attribution.

No problem.
Re: userCompletedAction -- that's correct; userCompletedAction will need a new overload on both the Android & iOS SDKs with a callback handler.

from cordova-ionic-phonegap-branch-deep-linking-attribution.

@pragunvohra This is currently in progress. We'll let you know once the changes are available.

from cordova-ionic-phonegap-branch-deep-linking-attribution.

@pragunvohra We're ready to merge in #92. Take a gander if you get a chance. Thanks!

from cordova-ionic-phonegap-branch-deep-linking-attribution.

@aaustin - just did, sorry I hadn't seen @jestoniyap's comment from last week.
Overall, it looks better. I would not replace boolean return values with strings though, and I think there are some possible memory leaks.
I left more detailed comments in the PR.

from cordova-ionic-phonegap-branch-deep-linking-attribution.

We're all set here, so I'm closing this issue out. Thanks for your help!

from cordova-ionic-phonegap-branch-deep-linking-attribution.