Add regional adblock about brave-browser HOT 12 CLOSED

@srirambv To enable Regional Ad Block, you need to set Brave's language to non-English using chrome://settings/languages. For instance, when I set my language to French, I see the following in chrome://adblock

Total Ads Blocked: 119
Regional Ad Block: Enabled
FRA: EasyList Liste FR

from brave-browser.

Yes, it looks like Windows is the special case where regional ad block can be fully controlled via the browser. On Mac and Linux, it relies on system level settings.

from brave-browser.

Merged here:
brave/brave-core@2242c6c

from brave-browser.

chrome://adblock shows regional ad block disabled.

@bbondy expected until the adblock UI is ready?

from brave-browser.

That's all that's expected for now, thx for checking

from brave-browser.

Verification passed on

from brave-browser.

@emerick this doesn't work on Linux. It doesn't show an option to Set what language is used to display. Having only French as the browser language it still shows as disabled. I'll add a new issue specific to Linux.

from brave-browser.

@srirambv It seems that on Linux, this is controlled via the LANGUAGE environment variable (see https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/D6Eoeh0G9Y4 for the gory details).

When launching on Linux like this, I saw the expected settings in chrome://adblock:

LANGUAGE=fr_FR ./brave

from brave-browser.

@emerick @bbondy I recently did country detection for Muon and noticed that the code you used @emerick doesn't always return country. For example, if you're in Columbia, I think it returns es-419 (Spanish spoken in Latin America / Caribbean)

Should regional adblocking be using language or country? Some locales returned (like fr-FR) DO specify the country, so locale may be specific enough in most cases

from brave-browser.

I believe in a followup I changed it so that if the full string is not found, it uses just the smaller part without the dash.

from brave-browser.

Verified that changing setting noted here #41 (comment) does not work for macOS. However, if I change that setting, my region, and my language as per #1238 (comment) then I can see that Regional Adblock is enabled.

Verified with

from brave-browser.

Verification Passed on

from brave-browser.