Comments (3)
Hi @egor-n ,
We can reproduce the issue and will update this thread with a fix. It does appear that the findFirstVisibleItemPosition()
methods are firing too late/early depending on the padding, like you're seeing.
from braze-android-sdk.
Hi @egor-n ,
Upon further inspection of the reported issue it doesn't look like we can support adding padding to the RecyclerView in that way. I would suggest some combination of the following (3. specifically):
- Modifying the
dimens/com_braze_content_cards_divider_height
value - Adding margin/padding to the surrounding container view of the RecyclerView instead of the
RecyclerView
itself. - Modifying
ContentCardsDividerItemDecoration
from braze-android-sdk.
@radixdev I ended up adding a new ItemDecoration
like so:
class VerticalPaddingDecoration(
private val paddingPx: Int
) : RecyclerView.ItemDecoration() {
override fun getItemOffsets(
outRect: Rect,
view: View,
parent: RecyclerView,
state: RecyclerView.State
) {
val itemPosition = parent.getChildAdapterPosition(view)
if (itemPosition == RecyclerView.NO_POSITION) {
return
}
if (itemPosition == 0) {
outRect.top = paddingPx
}
val adapter = parent.adapter
if (adapter != null && itemPosition == adapter.itemCount - 1) {
outRect.bottom = paddingPx
}
}
}
// custom ContentCardsFragment:
class MyContentCardsFragment : ContentCardsFragment() {
override fun onViewStateRestored(savedInstanceState: Bundle?) {
super.onViewStateRestored(savedInstanceState)
contentCardsRecyclerView?.let { recyclerView ->
recyclerView.addItemDecoration(
VerticalPaddingDecoration(
resources.getDimensionPixelOffset(
R.dimen.my_vertical_padding
)
)
)
}
}
}
from braze-android-sdk.
Related Issues (20)
- [Bug]: Crash in HTML IAM when calling `window.open` HOT 4
- [Bug]: Double Activity shows up on Android in Recents tasks when a Push Notification is Clicked HOT 5
- [Bug]: Braze Accent Color HOT 4
- [Bug]: ANR at Broadcast of Intent { act=com.safetyculture.iauditor.intent.BRAZE_SESSION_SHOULD_SEAL } HOT 6
- [Bug]: Black screen visible on Notification click with Android 14 HOT 1
- [Bug]: requestContentCardsRefresh() not refreshing the content cards HOT 2
- [Bug]: Strict Mode in In-app messages HOT 3
- [Bug]: In-app message disappears after blocking/minimizing the application HOT 3
- [Bug]: ContentCardFragment does not display first in-app message HOT 3
- [Bug]: Strict Mode DiskReadViolation HOT 3
- [Bug]: Android resource linking failed HOT 2
- [Bug]: Crash - NoSuchFieldError - No static field Key of type CoroutineExceptionHandler HOT 7
- [Bug]: StrictMode DiskReadViolation crash when clicking on a Content Card HOT 3
- [Bug]: getInstance(Context) method may unexpectedly provide different Braze instances HOT 5
- [Bug]: Register activity lifecycle callbacks HOT 3
- the return value of remoteMessage.getNotification() is null. HOT 4
- [Feature]: IsAnonymous getter for BrazeUser HOT 3
- [Bug]: Content Card is not enabled when upgrading Braze SDK HOT 10
- [Bug]: Notification runtime permission, POST_NOTIFICATIONS HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from braze-android-sdk.