Giter VIP home page Giter VIP logo

Comments (11)

Sebobo avatar Sebobo commented on June 12, 2024 1

We actually don't need so much. My first implementation mostly works and I was able to use the SelectBox from Neos and the Highlight plugin from CK5 https://ckeditor.com/docs/ckeditor5/latest/features/highlight.html#demo

I would prefer to use the Neos StyleSelect component, but it might need to be extended to give all the options.

@breadlesscode it could make sense to use the Highlight Plugin also for the normal buttons at some point. But it's not urgent.

from neos-simple-editor-extend.

Sebobo avatar Sebobo commented on June 12, 2024 1

I'm actually finished with the clients implementation, just having a problem with CK and Neos itself. When you include plugins that have dependencies on the CK core, you get errors and warnings in the backend. Everything still seems to work, but I wouldn't put it into production this way.
Will have a discussion with other UI people next week on how to solve this.

from neos-simple-editor-extend.

Sebobo avatar Sebobo commented on June 12, 2024 1

Just came back from holiday and was focused on the RedirectHandler. Can start on this topic next week :)
Maybe I'll just start a draft PR with some code and we can work on it together.

from neos-simple-editor-extend.

breadlesscode avatar breadlesscode commented on June 12, 2024

Thanks Seb for your support :)

Yes I think the StyleSelect should be fine. But atm I have no time to dive deeper in this component. I'm really curious to see what you implement 👍

from neos-simple-editor-extend.

breadlesscode avatar breadlesscode commented on June 12, 2024

@Sebobo Any progress here? If not I will have a look at this issue :)

That would be an awesome feature.

from neos-simple-editor-extend.

Sebobo avatar Sebobo commented on June 12, 2024

@breadlesscode finally took some time ;) You can already check out my draft PR #9 if you like.

from neos-simple-editor-extend.

breadlesscode avatar breadlesscode commented on June 12, 2024

Thank you :)

I will check that tomorrow

from neos-simple-editor-extend.

Sebobo avatar Sebobo commented on June 12, 2024

Open todos:

  • (Optionally) Make it possible to select style options instead of just css classes
  • Enable previous button plugin again (disabled because of some CK duplicate import error)
  • More testing

from neos-simple-editor-extend.

breadlesscode avatar breadlesscode commented on June 12, 2024

Sorry to keep you waiting. I did not forget you :)

This week I will have a look at your PR and hopefully fix the open Todos 👍

from neos-simple-editor-extend.

Sebobo avatar Sebobo commented on June 12, 2024

Oh I can also do that, but was sick last week. But feel free to change stuff if you are faster than me ;)

from neos-simple-editor-extend.

Benjamin-K avatar Benjamin-K commented on June 12, 2024

Any update on this?

from neos-simple-editor-extend.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.