Giter VIP home page Giter VIP logo

Comments (7)

deleugpn avatar deleugpn commented on May 29, 2024 1

The package automatically allows 0.0.0.0/0 which essentially would be the same as *, no?
Can you help me understand a use case that works with * only?

from laravel-bridge.

t-richard avatar t-richard commented on May 29, 2024 1

@mnapoli actually someone already went ahead and opened a PR brefphp/bref#1160

from laravel-bridge.

mnapoli avatar mnapoli commented on May 29, 2024 1

👍 it's merged and live: https://bref.sh/docs/frameworks/laravel.html#trusted-proxies

from laravel-bridge.

justijndepover avatar justijndepover commented on May 29, 2024

I'm relatively new to serverless so I'm not sure if I can provide much details.

In my case I have to overwrite the setting again or else my redirects, generated urls, asset urls, ... are all generated with the wrong domain.

from laravel-bridge.

buddhaCode avatar buddhaCode commented on May 29, 2024

In a brand new Laravel 8 installation, this package doesn't overwrite the trusted proxies configuration. The config @deleugpn mentioned only overrides the trusted proxy config, when the fideloper/TrustedProxy is used. I guess this package was used prior to Laravel 5.something.

from laravel-bridge.

t-richard avatar t-richard commented on May 29, 2024

Someone faced this issue again today (see brefphp/bref#1159)

I backtraced the issue to this PR in laravel laravel/framework#38295

Since laravel 8, they backported the Trustproxies middleware inside Laravel itself but dropped the possibility to configure it through config

In contrary to the original package, all configuration is done through overwriting properties

Not sure what is the proper Laravel way to handle this. Maybe we should just update the Bref documentation as it's done for Symfony ATM https://bref.sh/docs/frameworks/symfony.html#trust-api-gateway

from laravel-bridge.

mnapoli avatar mnapoli commented on May 29, 2024

@t-richard thanks a lot for tracking this!

Maybe our immediate option would be to document this then indeed. PRs are welcome!

from laravel-bridge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.