Giter VIP home page Giter VIP logo

Comments (8)

ryanbreen avatar ryanbreen commented on July 24, 2024

Yeah, that's a minimal change, and I could see how helpful it would be as an organizational principle. I'll take a look.

from git2consul.

petemounce avatar petemounce commented on July 24, 2024

Thanks! I hope it was clear in the original text, but on re-reading it I'm not sure - I'd particularly like the ability to mount repos at arbitary depths of the K/V store - at which point g2c would need to recursively create the structure above a particular mount point if it didn't exist.

We're migrating from config files to consul, and so consequently not all of our apps and tenants will move at once. Therefore, as they migrate, we'll have ... gaps ... in the structure until it fills itself in.

from git2consul.

ryanbreen avatar ryanbreen commented on July 24, 2024

Yep, it was clear. I'm pretty sure Consul doesn't care about intermediate directories in the KV namespace, so setting an arbitrary depth parent should just work.

from git2consul.

petemounce avatar petemounce commented on July 24, 2024

Ah, wonderful. Thanks :)

from git2consul.

ryanbreen avatar ryanbreen commented on July 24, 2024

I think GH-26 implements this. I'll push a new build if this looks good.

from git2consul.

ryanbreen avatar ryanbreen commented on July 24, 2024

This has been published as v0.10.0.

from git2consul.

petemounce avatar petemounce commented on July 24, 2024

Thanks!

I saw a tiny thing; your example in the readme starts with a /, but your
test forbids that.

Sent from my phone. Please excuse typos and brevity, but never text speak.
On 17 Jul 2015 17:24, "Ryan Breen" [email protected] wrote:

This has been published as v0.10.0.


Reply to this email directly or view it on GitHub
#25 (comment)
.

from git2consul.

ryanbreen avatar ryanbreen commented on July 24, 2024

Great catch! Fixed.

from git2consul.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.