Giter VIP home page Giter VIP logo

Comments (4)

ryanbreen avatar ryanbreen commented on July 24, 2024

Yeah, I didn't consider the Docker use case when first designing git2consul. I can definitely see how that would cause a problem. I'll give this some thought, but I'm also happy to take patches.

from git2consul.

devfacet avatar devfacet commented on July 24, 2024

I can implement ENV solution without making breaking changes. So basically we can set global.endpoint to GIT2CONSUL_ENDPOINT if --entrypoint is not provided.

Otherwise ( adding --entrypoint into config_seeder.js ) I can't see a solution without making breaking changes.

from git2consul.

satar avatar satar commented on July 24, 2024

I could also really use this solution. I need to be able to override consul server IP. I am not savvy with npm nor javascript for that matter. I know that I have been able to make this work by manually updating the following two hardcoded references to localhost:

in lib/index.js:
global.endpoint = "127.0.0.1";

in node_modules/consul/lib/consul.js:
opts.host || '127.0.0.1'

I would like to be able to specify this thru either a parameter or an environment variable. I am sure this is probably pretty easy to do but at a loss for how to do it. I would have thought passing --host when running the node would work but it did not.

from git2consul.

ryanbreen avatar ryanbreen commented on July 24, 2024

This is available in 0.12.0 and up.

from git2consul.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.