Merging a PR deletes ALL previews about climatelaboratorybook HOT 6 OPEN

#76 implements this but it doesn't work because the "delete preview" push to gh-pages gets cancelled before it does its thing.

from climatelaboratorybook.

Maybe the best approach is to set up a new action that runs after the rendered book is already pushed to gh-pages and simply checks out the gh-pages branch, deletes the appropriate _preview/[PR number] directory, and pushes the changes.

This action may be useful: https://github.com/marketplace/actions/add-commit

from climatelaboratorybook.

Or maybe a simpler one: https://github.com/stefanzweifel/git-auto-commit-action

from climatelaboratorybook.

Rather than running a delete action immediately upon merge, we could just run a daily or weekly "clean up" action that looks for anything in the _preview/ directory of the gh-pages branch, and removes anything not associated with a currently open PR.

For this, we would just need to be able to test if a given PR number is open.

from climatelaboratorybook.

Nevermind, I found a better / simpler solution.

In #77 We introduce a new delete_preview.yaml workflow that runs in the context

on:
  pull_request_target:
    types: closed

This means that it is called on merge OR on PR close, and either way it runs from the main branch so it has the credentials to push file changes to the gh_pages branch.

From there, it's just a matter of

• checking out the gh_pages branch
• deleting files in the appropriate _preview/[PR number] directory
• pushing those changes to the GitHub repo

Then the gh-pages automation takes over.

If you watch the action reports, it looks like this action gets skipped when the main deploy-book.yaml action pushes to gh-pages. But that's just the part where GitHub takes the files in the gh-pages repo and deploys them to the pages website. The important thing is that we get the file changes pushed into the repo.

I tested this all out, and found that:

• Previews are appropriately deleted when a PR is merged OR closed
• This does NOT conflict with or accidentally delete other preview for still-open PRs

So basically all the functionality is there!

Some more candy could be added, like:

• updating the message with the preview link to say that it's been deleted
• not posting the link until the pages are actually visible on GitHub pages (I'm not sure how to do that)

But I don't think any of that is necessary right now.

from climatelaboratorybook.

I should finish migrating this repo to use the reusable Pythia Cookbook actions (following the Cookbook Template). Will leave this issue open until that work is done.

from climatelaboratorybook.