Comments (2)
@smth I think the issue is with the underlying library (RGBaster.js) which does the color calculations. It seems to not be doing what it should when it returns colors.
Adaptive-backgrounds blindly uses the input from rgbaster
97 $parent.css({ backgroundColor: data.color });
Where data.color comes from:
77 $this.on( EVENT_CF, function(ev, data){
and
53 RGBaster.colors(img, {
54 paletteSize: 20,
55 exclude: opts.exclude,
56 success: function(colors) {
57 $this.attr(DATA_COLOR, colors.dominant);
58 $this.trigger(EVENT_CF, { color: colors.dominant, palette: colors.palette });
59 }
60 });
Based on this it seems to me that you may want to raise the case in RGBaster.js instead.
Another, more involved option, would be to replace rgbaster.js with something else. You may want to look at Lokesh's Color-Thief for that. Putting in this library at the right spots seems pretty straitforward.
from jquery.adaptive-backgrounds.js.
This should now be fixed.
As noted previously , there was an issue with the underlying RGBaster.js library which:
- skipped a high number of pixels
- only considered an area of 300 by 150px of the source image
- had some issues with transparent pixels and
- didn't keep a list of unique colors.
The latter issue is of no bearing to AD
Would you mind checking and validating if the issue still exists.
from jquery.adaptive-backgrounds.js.
Related Issues (20)
- use rgba instead of rgb HOT 1
- imageData varies greatly between bg image and img tag HOT 2
- Applying to another div other than the parent? HOT 8
- Getting Organized
- Apply to font colour HOT 1
- Return wrong dominant color in chrome, firefox but alright in safari HOT 6
- Parent element custom issue HOT 3
- Update Readme.MD for shade variations features HOT 4
- Respect 'opts.parent' when using 'data-ab-css-background'
- Performance with Background Images HOT 2
- Demos not work HOT 4
- Random selection for applying background-color HOT 1
- Dist folder in v1.0.3 HOT 1
- some images blocked by CORS policy HOT 2
- Any change of Video support HOT 1
- Rerunning $.adaptiveBackground.run(); ? HOT 2
- Image with wrong Dominant Colors HOT 1
- How can I extract color from the background and use it in border? HOT 1
- [question]adaptive with slidershow HOT 1
- About updating release with master branch files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jquery.adaptive-backgrounds.js.