Giter VIP home page Giter VIP logo

Comments (2)

AlfredJKwack avatar AlfredJKwack commented on July 3, 2024

@smth I think the issue is with the underlying library (RGBaster.js) which does the color calculations. It seems to not be doing what it should when it returns colors.

Adaptive-backgrounds blindly uses the input from rgbaster

97 $parent.css({ backgroundColor: data.color });

Where data.color comes from:

77 $this.on( EVENT_CF, function(ev, data){

and

53           RGBaster.colors(img, { 
54             paletteSize: 20, 
55             exclude: opts.exclude, 
56             success: function(colors) { 
57               $this.attr(DATA_COLOR, colors.dominant); 
58               $this.trigger(EVENT_CF, { color: colors.dominant, palette: colors.palette }); 
59             } 
60           });

Based on this it seems to me that you may want to raise the case in RGBaster.js instead.

Another, more involved option, would be to replace rgbaster.js with something else. You may want to look at Lokesh's Color-Thief for that. Putting in this library at the right spots seems pretty straitforward.

from jquery.adaptive-backgrounds.js.

AlfredJKwack avatar AlfredJKwack commented on July 3, 2024

This should now be fixed.

As noted previously , there was an issue with the underlying RGBaster.js library which:

The latter issue is of no bearing to AD

Would you mind checking and validating if the issue still exists.

from jquery.adaptive-backgrounds.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.