Giter VIP home page Giter VIP logo

Comments (10)

velajos avatar velajos commented on June 27, 2024 1

Greetings @brianleect since early yesterday I was testing the new change and it seems that everything is working perfectly. All the summaries are arriving every 15m and without delay. I will let you know if there is any news. Regards

from binance-pump-alerts.

brianleect avatar brianleect commented on June 27, 2024

Not too sure why this is happening. Surprised that it seems that you seem to receive some alerts earlier than the specified intervals. I was expecting a delay due to possible time taken for parsing and sending certain messages over time instead.

Currently the main telegram group has shifted over to the latest version. Will see if I can replicate the same issue faced.

from binance-pump-alerts.

velajos avatar velajos commented on June 27, 2024

Not too sure why this is happening. Surprised that it seems that you seem to receive some alerts earlier than the specified intervals. I was expecting a delay due to possible time taken for parsing and sending certain messages over time instead.

Currently the main telegram group has shifted over to the latest version. Will see if I can replicate the same issue faced.

Hello, thank you for replying.

Actually it's not that they are early, it's that they are late.

For example:
1st notification: 01:07 pm (should have arrived at 01:00 pm).
2nd notification: 01:25 pm (should have arrived at 01:15 pm)

Of course this does not happen all the time, it happens sometimes. Maybe it gets saturated when it has a lot of notifications to send and that's when this delay happens.

But as I said, it can be solved if the program could be restarted automatically from time to time.

from binance-pump-alerts.

brianleect avatar brianleect commented on June 27, 2024

@Juanjacinto123 Newest PR might be of interest to you. #70

Have not yet fully tested but shifted the version running in the telegram group over.
Will merge it with main once everything appears to work as intended.

Should fix the delay without needing to restart causing gaps of missing data by rounding down to nearest interval.

from binance-pump-alerts.

velajos avatar velajos commented on June 27, 2024

Greetings @brianleect , this correction you made works partially fine. By this I mean that for the hourly intervals, they arrive perfectly without delay. But for the case of the minute intervals, they also arrive fine but some reports are not generated.

See what happens in my case:

I use the hourly interval, but I also use the reports every 15 minutes.

After your correction now only the reports of the first 15 minutes after the hour and the last 15 minutes of the hour are coming. That is, if for example I am waiting for the 11:00 am reports, they arrive like this:

11: 15 Am and 11: 45 Am, (15m interval reports).

Before the correction they arrived like this:

11: 00 Am, 11:15 Am, 11:30 Am, 11:45 Am, 12:00 pm and so on every 15 minutes (with the problem of the slight delay).

And joining both intervals of one hour and 15 minutes, they arrive like this:

11:00 Am (hourly report).

11:15 Am (15 minutes report)

11:45 Am (15 minutes report)

12:00 Pm (hourly report)

In the past, they used to arrive like this:

11:00 Am (hourly report) and 11:00 Am (15 min report)

11:15 Am (15 minute report)

11:30 Am (15 minute report)

11:45 A.M. (15 minute report)

12:00 Pm (hourly report) and 12:00 Pm (15 minute report)

And so on.

Thank you for your response. Regards

from binance-pump-alerts.

brianleect avatar brianleect commented on June 27, 2024

@Juanjacinto123 Thanks for bringing up the issue.

Just noticed that the initial code I pushed actually adds an unnecessary interval time. Which makes sense for defined 15m intervals resulting in 30m interval actual reports.

What's a little confusing however is that this additional addition only seems to reflect on the 15m interval and not on the hourly based on what you are reporting?

image

Looking at the current public facing group, we see the 3h alerts firing every 6h instead which makes sense. Can you confirm that you are receiving your hourly report actually every hour instead of every 2h? (Or is it actually a 30m interval you set triggering)

from binance-pump-alerts.

brianleect avatar brianleect commented on June 27, 2024

I have removed the additional interval addition in the latest commit. Running 1h, 3h, 6h intervals on the main group now. Will see if this fixes the problem

from binance-pump-alerts.

velajos avatar velajos commented on June 27, 2024

@Juanjacinto123 Thanks for bringing up the issue.

Just noticed that the initial code I pushed actually adds an unnecessary interval time. Which makes sense for defined 15m intervals resulting in 30m interval actual reports.

What's a little confusing however is that this additional addition only seems to reflect on the 15m interval and not on the hourly based on what you are reporting?

image

Looking at the current public facing group, we see the 3h alerts firing every 6h instead which makes sense. Can you confirm that you are receiving your hourly report actually every hour instead of every 2h? (Or is it actually a 30m interval you set triggering)

Greetings my friend, happy holidays!

Well I tested it only with the 1h interval and apparently it worked fine sending the respective summary every hour. The problem appears when I add the 15m intervals, which is when the problem explained above occurs.

from binance-pump-alerts.

velajos avatar velajos commented on June 27, 2024

I have removed the additional interval addition in the latest commit. Running 1h, 3h, 6h intervals on the main group now. Will see if this fixes the problem

OK I'm going to try with this last update you made, with the 15m and 1h configuration. I will try a few hours and let you know if it is fixed. Thanks

from binance-pump-alerts.

brianleect avatar brianleect commented on June 27, 2024

Looks like everything is working well.

from binance-pump-alerts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.