Hi, I can't work out how this is actually working and gives correct

Question: how is operator overloading seemingly working? about money HOT 5 CLOSED

brick commented on July 22, 2024

Question: how is operator overloading seemingly working?

from money.

Comments (5)

solodkiy commented on July 22, 2024

May be it uses __toString() ?

from money.

solodkiy commented on July 22, 2024

Did you try more cases? Negative numbers, decimal, 11 vs 105 etc?

from money.

bendavies commented on July 22, 2024

We think php is comparing the internal properties of the objects (so value and scale)

I've managed to break it now.

var_dump(BigDecimal::of(100) > BigDecimal::ofUnscaledValue(1000, 2));

which is the same as 100 > 10.00 which should return true but returns false, since 100 > 1000;

from money.

BenMorel commented on July 22, 2024

Takeaway: don't do this 😉

Good find anyway, I didn't know PHP compared property-by-property in this case. IMO it's a shame that it does not just throw an exception here, until some kind of operator overload is implemented.

from money.

bendavies commented on July 22, 2024

Indeed, don't do this! Discovered as we using symfony's `GreaterThanOrEqual` on two `BigDecimal`s after migrating from floats, and discovered it still "worked".

…

On Sat, 12 Feb 2022, 22:18 Benjamin Morel, ***@***.***> wrote: Takeaway: don't do this 😉 Good finding anyway, I didn't know PHP compared property-by-property in this case. IMO it's a shame that it does not just throw an exception in this case, until some kind of operator overload <https://wiki.php.net/rfc/user_defined_operator_overloads> is implemented. — Reply to this email directly, view it on GitHub <#57 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEYV4DMZZT7JON2HNKZ4WTU23MBXANCNFSM5OES64VQ> . You are receiving this because you modified the open/close stateMessage ID: ***@***.***>

from money.

Recommend Projects