Comments (10)
I think I have fixed all of them.
from bridges-cxx.
setAssignment(int) is still documented as throwing an exception.
If the validation fails, bridges calls exit(EXIT_FAILURE), but this still doesn't throw.
from bridges-cxx.
I see a throw in the try block (for catching negative assignment numbers. Wouldnt that be caught in the catch block?
from bridges-cxx.
Yeah, exactly. The function throws internally, but also catches it internally, so for documentation purposes it shouldn't be declared as throwing an exception because it will always catch itself, without actually throwing to the user who is calling it.
And again I would recommend changing it like you have for the others. In that, since you already have a check for the throw, it would be better to put the catch calls in the if statement and leave the remainder in the else, without using a try/catch or manual throw altogether.
from bridges-cxx.
removed try/catch in setAssignment
from bridges-cxx.
Looks good, but it is printing the error message to cout.
This should be changed to cerr, to keep in line with similar situations.
from bridges-cxx.
fixed.
from bridges-cxx.
setAssignment still seems to be printing to cout not cerr. Additionally Bridges.h's server error msg and visualize functions are also printing to cout instead of cerr.
from bridges-cxx.
fixed.
from bridges-cxx.
visualize is still using cerr
Also since this is an if else list, I would exclude the explicit "None" check and just leave its code in an else statement at the end, that way if for some odd reason the visualizer type is not one of these types it will still be handled.
from bridges-cxx.
Related Issues (20)
- shouold getOSMdatafromjson be private? HOT 2
- add getters for shape collection properties HOT 1
- refactor Polyline to take points
- getuscitiesdata should check parameter names are valid HOT 2
- getdataJSON should not die if caching doesn't work
- urls in datasource should be crafted carefully
- Design a new caching object to keep track of space rather than number of documents
- Key/Mouse Click Support..
- replicate new input game API HOT 1
- 3d games features in C++ and java HOT 1
- document new input game api HOT 2
- Bar graph support.. HOT 1
- enable overriding cache location using environment variable
- bar chart support prototype in C++ HOT 1
- Refactoring Graph Classes..
- some attribtued hardcoded HOT 1
- data API
- map visualization
- setToolTipSuffix spacing
- Series Label Allignment
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bridges-cxx.