Giter VIP home page Giter VIP logo

Comments (5)

krs-world avatar krs-world commented on August 30, 2024

Fixed.. ADTVisualizer includes the element classes and Bridges.h just includes ADTVisualizer.h. The JSON strings are made constant and private.

from bridges-cxx.

dcarmer avatar dcarmer commented on August 30, 2024

Cool, I wasn't sure if you wanted each header to directly include each file, or if an included file included one that would be enough, but its clear now.

That's why I would suggest not including TreeElement, as BSTElement is derived from, and therefore includes TreeElement already.

from bridges-cxx.

krs-world avatar krs-world commented on August 30, 2024

ah yes, updated my version.. I missed that one.

from bridges-cxx.

dcarmer avatar dcarmer commented on August 30, 2024

While we're on the subject, string is included in a multitude of files, so I'm assuming that the paradigm we're using is: We leave out bridges header files that we know are included within other included files, but we also explicitly include c++ libraries in each header that needs it.

If this is the case SLelement, as well as DLelement should include string. If not than I can provide a more specific list of files that are unnecessarily including c++ headers.

from bridges-cxx.

krs-world avatar krs-world commented on August 30, 2024

Those two files include Element, which includes string. I have fixed up the
includes issue..

from bridges-cxx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.