Giter VIP home page Giter VIP logo

Comments (7)

brigand avatar brigand commented on May 18, 2024

Hmm... we might want to add an option for adding a NODE_ENV check so minifiers can strip it for production.

from babel-plugin-flow-react-proptypes.

faceyspacey avatar faceyspacey commented on May 18, 2024

yea, but aren't the propTypes removed in production automatically??

from babel-plugin-flow-react-proptypes.

brigand avatar brigand commented on May 18, 2024

Nope. React doesn't check them in production, but they're still in the code.

from babel-plugin-flow-react-proptypes.

sohkai avatar sohkai commented on May 18, 2024

Hmm... we might want to add an option for adding a NODE_ENV check so minifiers can strip it for production.

@brigand Was this ever implemented? AFAIK consumers of a library won't be able to run babel plugins like babel-plugin-transform-react-remove-prop-types on their imports unless they get messy with their node_modules so the only chance they have of stripping out prop types would be if the library had their prop types under NODE_ENV flags.

from babel-plugin-flow-react-proptypes.

brigand avatar brigand commented on May 18, 2024

Yeah, we could add this, and since require('prop-types') is inline, it'll get hit by dead code elimination. I'll be pretty busy the next few days, but I'll add a reminder to do this if no one gets to it first.

from babel-plugin-flow-react-proptypes.

sohkai avatar sohkai commented on May 18, 2024

Cool! I don't mind helping out if you need some :).

from babel-plugin-flow-react-proptypes.

brigand avatar brigand commented on May 18, 2024

@sohkai I'd love some help!

from babel-plugin-flow-react-proptypes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.