Giter VIP home page Giter VIP logo

Comments (17)

nciske avatar nciske commented on June 12, 2024

Thanks for reporting this! We'll look at pushing a fix.

from geometa-acf.

niedakh avatar niedakh commented on June 12, 2024

Hi, any hints how to fix this, where to look for the bug? I could do a PR if you guide me.

from geometa-acf.

stuporglue avatar stuporglue commented on June 12, 2024

from geometa-acf.

stuporglue avatar stuporglue commented on June 12, 2024

Hi again Piotr,

Can you tell me more about how your ACF field is defined?

I'm testing with ACF rules like this, and it's working (default Post type and default taxonomy term category).

image

Also, how did you install Geometa For ACF? From the plugin repository, or from GitHub?

Thanks,
Michael Moore

from geometa-acf.

niedakh avatar niedakh commented on June 12, 2024

Hi,

tested with both, neighter plugin repository nor github works in the case you show. this is how the field looks like:

image

image

from geometa-acf.

niedakh avatar niedakh commented on June 12, 2024

i'm using wp geometa 0.3.4 and acf 4.4.11 the map editor renders correctly on posts with these settings

from geometa-acf.

niedakh avatar niedakh commented on June 12, 2024

Can I just force put the javascript link ref in the admin page somewhere to get this working asap as a workaround?

from geometa-acf.

stuporglue avatar stuporglue commented on June 12, 2024

Thanks for the screenshots, I was able to reproduce the issue and think I have it fixed. Please let me know if it doesn't work for you now.

The 0.0.5 beta release is here:
https://github.com/BrilliantPlugins/geometa-acf/releases/tag/0.0.5-beta

If you'd like to see what changed, it was in leaflet-php and the changes are here:

I missed the fact that since ACF 4 loads the fields via an admin-ajax call, the header scripts and styles were never dequeued in leaflet-php. This change dequeues them the first time a map is printed.

This is a beta release and I have not tested it as thoroughly as I will before the actual release. As such, there may be bugs, so please test before deploying.

from geometa-acf.

niedakh avatar niedakh commented on June 12, 2024

Hi,

it still doesn't work for me - i've setup a wp-latest from scratch took the plugin from your prerelease, set it up exactly like earlier, here's the debug console now:

zrzut ekranu 2017-09-10 o 00 28 05

from geometa-acf.

stuporglue avatar stuporglue commented on June 12, 2024

I'm no longer able to reproduce the error here, but I thought of what should be a more robust way to ensure that the required libraries get loaded.

The problem is that there's no map on the page when the page loads, so the usual wp_enqueue_script doesn't load Leaflet or the Leaflet plugins. Instead, the ACF field gets loaded by ajax after the main page loads.

Please uninstall the version of geometa-acf that you have installed and try the version attached here:

geometa-acf_0.0.5-beta2.zip

Thanks,
Michael Moore

from geometa-acf.

niedakh avatar niedakh commented on June 12, 2024

Unfortunately the map is still not there with acf 0.0.5beta2 and newest acf4 and newest wordpress.

from geometa-acf.

stuporglue avatar stuporglue commented on June 12, 2024

Can you try disabling all plugins except ACF and Geometa for ACF and see if the map appears then?

Perhaps there's an unexpected conflict with another plugin. If the map does appear with other plugins disabled, tracking down which plugin Geometa for ACF conflicts with would be the next step.

Thanks,
Michael

from geometa-acf.

niedakh avatar niedakh commented on June 12, 2024

I've disabled all plugins left just geometa for acf, wp-geometa and acf. still not working.
image

from geometa-acf.

stuporglue avatar stuporglue commented on June 12, 2024

from geometa-acf.

niedakh avatar niedakh commented on June 12, 2024

Plugin Name | WP-GeoMeta Version
GeoMeta for ACF | 0.3.3
WP-GeoMeta (In Use) | 0.3.3

disabling wp-geometa causes javascript errors in missing properties of objects and the map does not load

from geometa-acf.

niedakh avatar niedakh commented on June 12, 2024

it also says

Odd Situation! You have the latest version of WP-GeoMeta, but another plugin is providing an older version WP-GeoMeta-Lib Please update the plugin(s) not providing version 0.3.3 in the list below!

from geometa-acf.

niedakh avatar niedakh commented on June 12, 2024

(but all of them provide 0.3.3)

from geometa-acf.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.