Comments (3)
stefanpenner
commented on June 27, 2024
Windows test is failing at broken link test because of nodejs/node#30538
context: #117 (comment)
commit to fix in node: pd4d10/node@842dcf3
TL;DR: bug in node, hopefully they release new patch versions with the fix soon. If not, we can consider skipping those tests. @Turbo87 thoughts?
from broccoli-funnel.
Turbo87
commented on June 27, 2024
is that a problem in our tests or in the library code? I'm wondering if we need a workaround for the node versions that have this bug?
from broccoli-funnel.
stefanpenner
commented on June 27, 2024
TL;DR existsSync is sorta broken. We could provide a wrapper that likely works around it, but we can't really guarentee all other usages of it in an app are using said wrapper. I kinda think (unless this appears in bug reports) that @SparshithNR approach of getting node core to fix is the right path.
But i can be convinced.
from broccoli-funnel.
Related Issues (20)
- funnel is copying the entire folder instead of a single file HOT 2
- Funnel with missing inputNode fails if include and/or exclude are set HOT 1
- allowEmpty: false isn't throwing an error when no files match HOT 1
- Run time error: Merge error: file already exists, pass option { overwrite: true } HOT 1
- [3.0.1] Relative path is expected, path / is an absolute path. HOT 3
- [3.0.1] destDir not respected HOT 7
- [3.0.0] Leading / in destDir is treated as ROOT directory HOT 5
- srcDir can no longer contain a leading slash HOT 1
- Windows issues HOT 16
- Folders are not properly excluded HOT 2
- Incompatible with heimdalljs 0.1.3? HOT 17
- This project appears to introduce 581 files via itself and its deps HOT 4
- explore passing excludes to walkSync when possible
- Exception is thrown in 1.0.8 with relative paths in broccoli-funnel HOT 3
- Cannot set property 'patches' of undefined HOT 5
- "ENOENT: no such file or directory" when deleting a file HOT 23
- Pass the changes to out when linking roots
- [PERF] potentially unneeded matching
- [DEPRECATE] RegExp's in include / exclude
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from broccoli-funnel.