When using `pnpm`, a module that uses `Buffer.isBuffer` fails to bundle about browserify HOT 2 OPEN

If something works with npm, and not with an alternative package manager, then it seems likely to be a bug in that package manager. If pnpm, or yarn, or anyone else is placing things in a different location than npm does, then it's responsible for also ensuring that standard module resolution APIs act as if things are in an npm-installed location.

Have you filed an issue on pnpm to investigate? If there's something in browserify then a fix ofc can be investigated, but it seems worth checking with pnpm first.

from browserify.

Hi @ljharb, thanks for mentioning it! About opening it on pnpm, from what I read yesterday, when an issue is tooling related, it's something that pnpm wont solve, according to this:

pnpm/pnpm#801

Also, we had a similar issue in the past which was open there and solved in browserify/module-deps:

pnpm/pnpm#795
browserify/module-deps#133

I ended up deciding to open it here because I saw an issue that involved the same package (is-buffer), which was solved in browserify/insert-module-globals:

#1825.
browserify/insert-module-globals#75.

Also, since it has something to do with patching Buffer.isBuffer (which seems to be browserify's responsibility) I thought this would be the right place.

One more thing to add, if I change the call in browserify/insert-module-globals from path.relative to path.resolve, it ends up bundling things correctly:

diff --git a/index.js b/index.js
index dfc2664..3c35f03 100644
--- a/index.js
+++ b/index.js
@@ -10,7 +10,7 @@ var isbufferPath = require.resolve('is-buffer')
 var combineSourceMap = require('combine-source-map');
 
 function getRelativeRequirePath(fullPath, fromPath) {
-  var relpath = path.relative(path.dirname(fromPath), fullPath);
+  var relpath = path.resolve(path.dirname(fromPath), fullPath);
   // If fullPath is in the same directory or a subdirectory of fromPath,
   // relpath will result in something like "index.js", "src/abc.js".
   // require() needs "./" prepended to these paths.

However, there's one test that ends up failing because of this: https://github.com/browserify/insert-module-globals/blob/0549e4372523ec2c967058b0bfce51fad9038b0f/test/isbuffer.js#L22.

from browserify.