Comments (6)
Hi Jon,
Yeah, having the urls encoded does seem a bit weird, but as mentioned in the readme there is not a lot we can do about this:
Note 2: These urls will be url-encoded in all HTML4 Browsers except Opera as it does not url-encode the urls. The url-encoding is necessary for these browsers as otherwise it won't work (the hashes won't actually apply). There is nothing we can do about this.
Someone (me, you?) will have to do a up a proper report on which HTML4 browsers (and versions) actually require the url-encoding, as maybe there are other workarounds that could be used.
from history.js.
Sorry I didn't read the readme. This does make me sad. I'll take a look at the code to better understand the issues. I might have to avoid data persistence for now as my client will likely not accept URLs with that much encoding.
from history.js.
Sorry to hear that. Here are the options though - which may just work:
- Remove the URL encoding. Check to see which browsers fail - by running the tests.
- For the browsers which fail, perform the URL encode however do a
.replace(encodedEntity,normalEntity)
after the escape to discover which entities are actually allowed - perhaps they fail on hashes that contain things like!@#$%^&*()_
but not on hashes that just contain-/_?&
- worth investigation.
If you're willing to look at this, that'll help a ton :) Right now I'm focusing on getting IE browsers working with the latest dev branch. Feel free to add me on Skype (username balupton) and I'll help you out if you'd like to tackle this yourself :)
from history.js.
I've been able to make progress on this. Firefox 3 and Opera 11 are fine with some url entities allowed in their normal form. Will test in IE.
from history.js.
IE6 requires the entire hash to be encoded to work properly. A bit unfortunate, but oh well. FF3.6 and IE7,8,9 only require some parts. And Opera 10,11 ignore the encoding.
from history.js.
v1.6 is now out which fixes this issue. Marking as resolved and closing :D
from history.js.
Related Issues (20)
- Few test cases are failing on X86. Saying "operation insecure"
- How to use History API State with hash urls?
- IE/Edge pop last saved object irrespective of current URL
- change url cross domain
- native.history.js detected as virus HOT 1
- No default jsDelivr CDN file set
- jquery.history.js breaks the script adn return "History.js Adapter has already been loaded..." error.
- replaceState removes first character of hash (#) when it contains dot "."
- indicating locale code to url
- Problems with webpack encore at page loading
- The Solutions section is missing the hashtag solution
- Change domain "mysite.com/page1" to "mysite.com"
- npm WARN deprecated: Update deprecated dependencies HOT 1
- history.goback() is not working for mozilla firefox
- page is not jump used push HOT 1
- OnPopState calls in case of section change
- Back Button Error while using with VueJs Data
- Revise tests
- How to unbind function from History.Adapter.bind? HOT 1
- security scan result HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from history.js.