Giter VIP home page Giter VIP logo

Comments (5)

bsoyka avatar bsoyka commented on July 20, 2024 1

You can run the tests with this:

python -m unittest tests/test_main.py

from gravify.

mfaheemakhtar avatar mfaheemakhtar commented on July 20, 2024

Hey @bsoyka, I can take it.

What do you think about using

DEFAULT_IMAGE = {
  '404': '404',
  'MYSTERY_PERSON': 'mp',
  'IDENTICON': 'identicon',
  'MONSTERID': 'monsterid',
  'WAVATAR': 'wavatar',
  'RETRO': 'retro',
  'ROBOHASH': 'robohash',
  'BLANK': 'blank'
}

Usage

gravify.Gravatar.DEFAULT_IMAGE['RETRO']

instead of

  Type_404 = "404"
  Type_mystreyPerson = "mp"

Usage

gravify.Gravatar.RETRO

from gravify.

bsoyka avatar bsoyka commented on July 20, 2024

Hey, @mfaheemakhtar! I like your idea! A couple small changes, let me know your thoughts:

DEFAULT_IMAGES = {
  '404': '404',
  'mystery_person': 'mp',
  'identicon': 'identicon',
  'monsterid': 'monsterid',
  'wavatar': 'wavatar',
  'retro': 'retro',
  'robohash': 'robohash',
  'blank': 'blank'
}

Also, when you make your PR, make sure you add a test or two to make sure it works.

from gravify.

mfaheemakhtar avatar mfaheemakhtar commented on July 20, 2024

Hey @bsoyka , how do you run unit tests?

python3 ./tests/test_main.py

from gravify.

bsoyka avatar bsoyka commented on July 20, 2024

Closed via #25

from gravify.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.