Comments (8)
I just stumbled upon this https://code.google.com/p/android/issues/detail?id=193679. Looks like there is a bug in the build tools with no workaround. I believe removing your label should fix the problem. I can submit a pull request with the proposed change.
from gandalf.
Feel free to submit a PR, always appreciate the help.
from gandalf.
Ah, this is a good catch. This is caused by the fact that you have hard coded the label value inside your application block. I will include a fix for this in the next release, in the meantime you can create a string resource like so <string name="app_name">ClinicalKey DEBUG</string>
and setting your application label to android:label="@string/app_name"
.
Great find, thanks for reporting this.
from gandalf.
The hardcoded value is on in my debug/AndroidManifest.xml. I get the same error when building release which uses a string resource:
Attribute application@label value=(@string/clinicalkey_title) from AndroidManifest.xml:20:9-50
is also present at [com.btkelly:gandalf:1.3.0] AndroidManifest.xml:15:9-41 value=(@string/app_name).
Suggestion: add 'tools:replace="android:label"' to element at AndroidManifest.xml:15:5-417:19 to override.
from gandalf.
Seems like the issue is I am using the tools:ignore attribute with the tools:replace and that is the bug in the linked android bug report. Only workaround I have found is removing the tools:ignore attribute.
from gandalf.
The issue comes from the fact that the label is already defined and cannot be different. If you update your label string resource name to app_name
instead of clinicalkey_title
for all build types this should resolve the issue. When the merging occurs it will replace the library version of app_name
with your version. This is still a work around and I would like to resolve it by removing the label from the lib itself.
from gandalf.
Ahh, you are right, that did the trick. Thanks! Great work on the library by the way. Working on a prototype to build this into our app and stumbled upon this library. Need to convince the team its worthy of using and hopefully the iOS guys like iOS version as well. Anyway, I am going to submit a PR. Do you think any of that application tag is necessary? Most libraries don't have one at all.
from gandalf.
Probably not, you can pull everything and just test compilation with the built in example app. If that works fine should be good to go.
from gandalf.
Related Issues (20)
- Fix Travis build issue with javadoc generation
- Add screenshots from example app to README/page HOT 2
- Update README for custom dialog content
- Major versions and minor versions not supported HOT 3
- Download update from custom url HOT 3
- The library is outdated in jcenter repository HOT 6
- Blocking alert not shown when user skips optional update HOT 5
- Auto install apk when using FileDownloadUpdateListener HOT 9
- Asyncronous update checking HOT 3
- Update dependencies to the current latest versions HOT 2
- Semantic version numbers can cause app crash HOT 20
- Add the ability to set a custom version checker
- Add a debug mode to the installer HOT 1
- Gradle Error: Cannot create variant 'android-lint' after configuration ':gandalf:debugRuntimeElements' has been resolved HOT 2
- Add check when application is foregrounded.
- Gandalf not working in Samsung 10 HOT 1
- Found DiskReadViolation when strict mode enabled HOT 1
- StrictMode policy violation found when doing Gson mapping from onResponse() call HOT 3
- Consider adding an dependency other than jCenter?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gandalf.