Comments (14)
Nope. Can you tell me why I should use Less instead of SCSS?
from bootstrap-switch.
Because Bootstrap uses Less ? I thought it was weird to use Scss in the first place.
Actually, using Scss makes integration with bootstrap more difficult, especially with some bootstrap themes and variables https://github.com/twitter/bootstrap/blob/master/less/variables.less
I think bootstrap-switch is great and should belong to Bootstrap :-)
from bootstrap-switch.
Yeah, we would love to have a .Less file that uses bootstrap variables so we can just build it with our styles, instead of string replacing/overriding the duplicate colors/themes.
A lot like: https://github.com/eternicode/bootstrap-datepicker
from bootstrap-switch.
Ok, can you check out this branch? If it's ok I'll merge it to master.
from bootstrap-switch.
@iesta @markmarkoh can you give me feedback please?
from bootstrap-switch.
@nostalgiaz sorry! I checked out the branch last week and added an @import into our bootstrap.less (and removed the variables/mixin @imports), everything worked great. All of our variables were brought in and bootstrap-switch was styled automatically to match our theme.
Very cool for you to do this, thanks. Are you planning to maintain both the .scss and .less?
(FTR, I have nothing against .scss, I just love the idea of bootstrap UI widgets being so compatible).
from bootstrap-switch.
I don't think I have the time to maintain both the .scss and .less. My idea is to merge .less to master and say goodbye to .scss :P
The changes you done are useful for everyone or just for you?
from bootstrap-switch.
Possibly, here's what I did:
https://github.com/markmarkoh/bootstrap-switch/tree/features/less/static/less
styles.less brings in variables/mixins if necessary. For teams that throw boostrapSwitch.less into their build, they can just move that file.
I don't have enough knowledge of other team's workflows to make to know whether or not this is useful for them. @iesta, thoughts?
from bootstrap-switch.
Works great for me too asis.
Now I'll try to get it working in the rails asset pipeline. For some reason, something is not working.
Thanks for the fast response.
from bootstrap-switch.
i was just running into this today. I do find having the deps folder there messy.
from bootstrap-switch.
My branch gets around the deps folder a bit.
On Mar 7, 2013 1:26 PM, "Daniel A. White" [email protected] wrote:
i was just running into this today. I do find having the deps folder
there messy.—
Reply to this email directly or view it on GitHub.
from bootstrap-switch.
that would work for me. thanks @markmarkoh! could you get a pull over here?
from bootstrap-switch.
Here we go! 583032b Goodbye scss, welcome less :)
from bootstrap-switch.
@markmarkoh can you fix the code and then send us a pull request?
from bootstrap-switch.
Related Issues (20)
- bootstrap switch check box is not display ON when I have refreshed the page with value TRUE HOT 2
- When will 3.4 be pushed as an official release
- getClasses function's filter works contrawise
- Allow handle-width with percentage
- Bug when using Bootstrap 4 sass - scss file integration with the switch HOT 5
- Keyboard support
- Warning: This project is dead and it does not work anymore HOT 5
- Thousands of bootstrap-switch: Forced reflow is a likely performance bottleneck.
- Home page has wrong version posted
- SyntaxError: expected expression, got '.'
- Need to update Docs "Documentation" dropdown links
- the master branch have a bug HOT 1
- Use Array.isArray instead of jQuery.isArray
- Switch with Angular
- Space in data-label-text create two lines
- Wrapper width show part of the second option in Edge HOT 1
- Class definitions not created on outer div HOT 4
- Sorry to raise this issue again.
- Switch button is not showing as ON for default checked value HOT 1
- SCSS file: can't find stylesheet to import HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bootstrap-switch.