Giter VIP home page Giter VIP logo

Comments (5)

seegrand avatar seegrand commented on August 23, 2024 1

This is the composer patch we used to fix it temporarily:

Buckaroo Github issue: https://github.com/buckaroo-it/Magento2/issues/56
===================================================================
--- /vendor/buckaroo/magento2/view/frontend/web/js/view/payment/method-renderer/creditcard.js
+++ /vendor/buckaroo/magento2/view/frontend/web/js/view/payment/method-renderer/creditcard.js
@@ -75,7 +75,11 @@
                     }
                     this.creditcards = ko.observableArray(filteredCards);

-                    this.selectionType  = window.checkoutConfig.payment.buckaroo.ideal.selectionType;
+                    if (window.checkoutConfig.payment.buckaroo.ideal){
+                        this.selectionType = window.checkoutConfig.payment.buckaroo.ideal.selectionType;
+                    } else {
+                        this.selectionType = "1";
+                    }

                     /**
                      * observe radio buttons

It hardcodes the selectionType to radio buttons (use "2" for dropdown) because when the iDeal payment method is disable, this object is not available in the creditcard conifg. But hey, it's something.

from magento2.

paul-stolk-webdiensten avatar paul-stolk-webdiensten commented on August 23, 2024

Same here. I was able to solve it with:

if(window.checkoutConfig.payment.buckaroo.ideal){this.selectionType=window.checkoutConfig.payment.buckaroo.ideal.selectionType;}

But it would make more sense to use creditcard.

This is about https://github.com/buckaroo-it/Magento2/blob/master/view/frontend/web/js/view/payment/method-renderer/creditcard.js#L78

from magento2.

Buckaroo-Rens avatar Buckaroo-Rens commented on August 23, 2024

@paul-stolk-webdiensten Thank you for the information. We will try to research this a.s.a.p. Did you test on Buckaroo v1.26.0?

from magento2.

paul-stolk-webdiensten avatar paul-stolk-webdiensten commented on August 23, 2024

@paul-stolk-webdiensten Thank you for the information. We will try to research this a.s.a.p. Did you test on Buckaroo v1.26.0?

Buckaroo 1.26.0, Magento ver. 2.3.3-p1.

from magento2.

Buckaroo-Rens avatar Buckaroo-Rens commented on August 23, 2024

The issue is fixed from Buckaroo version 1.28.0

from magento2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.