Comments (4)
Hi, may I take this one?
from ockam.
@pradovic sure, go ahead
from ockam.
@SanjoDeundiak Thanks! Finally got the time to take a look.
If I understand correctly the error in processor or worker initialize
function error is just logged by WorkerRelay
.
#[cfg_attr(not(feature = "std"), allow(unused_mut))]
#[cfg_attr(not(feature = "std"), allow(unused_variables))]
async fn run(mut self, mut ctrl_rx: SmallReceiver<CtrlSignal>) {
match self.worker.initialize(&mut self.ctx).await {
Ok(()) => {}
Err(e) => {
error!(
"Failure during '{}' worker initialisation: {}",
self.ctx.address(),
e
);
}
}
If I understood correctly this does not stop the worker, but just logs the error. The proposed solution would be to move on to the worker shutdown and context stop ack, without starting the loop in between:
#[cfg_attr(not(feature = "std"), allow(unused_mut))]
#[cfg_attr(not(feature = "std"), allow(unused_variables))]
async fn run(mut self, mut ctrl_rx: SmallReceiver<CtrlSignal>) {
match self.worker.initialize(&mut self.ctx).await {
Ok(()) => {}
Err(e) => {
error!(
"Failure during '{}' worker initialisation: {}",
self.ctx.address(),
e
);
// call self.shutdown & ctx.send_stop_ack
shutdown_and_stop_ack(&mut processor, &mut ctx, &ctx_addr).await;
return;
}
}
Processor is behaving in the same fashion, so I posted worker as a reference.
from ockam.
I have opened the PR with proposed change: #7654. Pls correct me if I am wrong and I will be happy to fix it.
from ockam.
Related Issues (20)
- Ockam Portals OS Requirements not indicated in docs
- `ockam node create --identity X` should fail if `X` doesn't exist HOT 7
- Calling `make nix_elixir_build_ockly` on macos fails to build ockly crate on develop HOT 1
- Add a bats test checking that the user creating a project, has the ability to enroll new enrollers into it
- Easy workflow to reliably measure latency within ockam
- Improve ockam routing performance
- Better error reporting for secure channel API client
- Creating an identity on a aws kms vault fails
- Flow to benchmark the project performance on EC2
- Diagnose why this Elixir test sometimes fails in CI
- Replace unmaintained transitive dependency `yaml-rust`
- Report unused dependencies in CI HOT 1
- Improve type-safety for Identity arguments in `ockam_command` HOT 2
- Ockam example runs automated tests to ensure examples don't break
- Redpanda serverless are working and supported
- Kafka inlet and outlet supports ABAC policies
- Single command stress test project environments
- Allow to use `self` route to specify the same node
- Kafka consumer/producer/direct are replaced by Kafka inlet/outlet
- Kafka examples are using the new `kafka-inlet create`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ockam.