Telegraph WebSocket Server kills the connection when sending a data flood about telegraph HOT 8 CLOSED

Fixed in 0.17

from telegraph.

The WebSocket implementation in Telegraph is kinda bare bones, but it should be functional. Do you perhaps have a test project for me to illustrate the problem? A project with Telegraph and Starscream would be great, then I can see how Telegraph responds. I've tested Telegraph with the WebSocket client in Chrome and that worked fine.

from telegraph.

Thanks for the reply :)

I've created a test application that simulates some of my actual app flow, however the issue currently doesn't reproduce. I'll investigate the matter and post again once I found a reason and/or solution.

I did notice that the rate of sending data over the server's websocket drops from the expected 1MB/s to about 0.3MB/s (the data I'm sending is H.264 encoded video @ 1080p, 8Mb/s using VideoToolbox on the server device end). In addition the client's return messages don't seem to be received by the server.

This might be a bug on my end, but the test application also has an implementation with PocketSocket WebSocket Server, which seems to keep a steady transmission rate, and receives the messages sent from client without an issue.

from telegraph.

I have the same issue, but only when sending many packets to clients very quickly. I'll try and get a test app made..

from telegraph.

I am also having this issue.

The setup is basic:

• A macOS WebSocket server and an iOS WebSocket client
• iOS app generates 3MB of random Data and sends it to server via WebSocketClient.send(data:)

Result is occasionally getting this:

[CLIENT] WebSocket disconnected, error: Error Domain=NSPOSIXErrorDomain Code=32 "Broken pipe" UserInfo={NSLocalizedDescription=Broken pipe, NSLocalizedFailureReason=Error in write() function}

...or, if not, a quiet and gracefully closed connection. No matter what, the connection always gracefully closes, instead of sending the data, as expected.

Test applications are here:
macOS (Server) - https://github.com/joshavant/BrokenPipeDemoDesktop
iOS (Client) - https://github.com/joshavant/BrokenPipeDemo

Repro Instructions:

1. Run macOS WebSockets server application
2. Run iOS WebSockets client application
3. Observe in macOS console that iOS client has connected to WebSockets server
4. Wait 2 seconds for iOS to automatically send 3MB of random data via WebSockets connection

Expected Behavior: Data is successfully received by macOS application
Actual Behavior: Data is not successfully received by macOS application and WebSockets connection closes

from telegraph.

@joshavant Thank you so much for the demo applications.

This problem was caused by an issue in the WebSocket parser. I've fixed that issue in commit ed55f1a

Your demo applications now work as they should. You can try it out yourself by replacing the Telegraph line in your podfiles with:

pod 'Telegraph', :git => 'https://github.com/Building42/Telegraph.git'

If you run into any errors about Swift versions, please set a Swift language version on your project:

I'll probably release a new version of Telegraph tomorrow. There are a few threading improvements that I'm finishing up that I want to add to the new release.

from telegraph.

@chajuss @Joebayld Can you please try the new commit of Telegraph? It will probably fix your websocket issues. Use this in your podfile to try it out:

pod 'Telegraph', :git => 'https://github.com/Building42/Telegraph.git'

from telegraph.

Sorry, I used PocketSocket for now, however I will give Telegraph an extra shot once I'll get the time to do the switch.

from telegraph.