Giter VIP home page Giter VIP logo

Comments (8)

hhhorb avatar hhhorb commented on June 22, 2024

Fine by me.

from bunsen-configs.

johnraff avatar johnraff commented on June 22, 2024

Which are these "dark icons"? The default light grey faenza are visible.

btw I see no difference between faenza-bunsen and faenza-dark-bunsen in most situations.

from bunsen-configs.

hhhorb avatar hhhorb commented on June 22, 2024

I see no difference between faenza-bunsen and faenza-dark-bunsen in most situations

I was going to bring this up, it doesn't seem like the bunsen icons were packaged correctly. For example, installing faenza-icon-theme from jessie instantly solves the invisible pnmixer icon (probably volumeicon too).

I'll see what I can find and post back.

from bunsen-configs.

johnraff avatar johnraff commented on June 22, 2024

I'll see what I can find and post back.

Please.

Although, I saw the same lack of difference when on #! too. At that time I seem to remember being told the "dark" meant that the icons were meant for use on dark backgrounds, rather than that they were dark themselves.

from bunsen-configs.

hhhorb avatar hhhorb commented on June 22, 2024

I'll see what I can find and post back.

https://github.com/2ion/bunsen-org/issues/107#issue-112065606

Although, I saw the same lack of difference when on #! too

Maybe Philip's error that we've carried over, then.

At that time I seem to remember being told the "dark" meant that the icons were meant for use on dark backgrounds, rather than that they were dark themselves.

This is correct, "Faenza-Bunsen-Dark" should be the default icon theme for use with our tint2conf.

from bunsen-configs.

johnraff avatar johnraff commented on June 22, 2024

I remember having to use "dark" at some point to make a volume icon visible.

from bunsen-configs.

johnraff avatar johnraff commented on June 22, 2024

I think this issue might be fixed by the icon repackaging @hhhorb suggested elsewhere. If we provide only the folder icons and inherit the rest from Faenza some things will become simpler.

"Faenza-Bunsen-Dark" should be the default icon theme for use with our tint2conf.

This is how BL is configured OOTB. ("Faenza-Dark-Bunsen" that is)

from bunsen-configs.

johnraff avatar johnraff commented on June 22, 2024

Icon theme discussion here: BunsenLabs/bunsen-faenza-icon-theme#2

from bunsen-configs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.