Comments (7)
If it's re-usable, then the function can be put in the library. If it's not, it doesn't belong in a library -> seems reasonable to me.
from bunsen-pipemenus.
For example, browserExists(), screenshooterExists could be replaced by appExists(), slightly rewritten to allow different arrays to be accessed. Such an appExists() might be re-usable in a different part of the forest.
BTW is .cfg really a suitable file ending for a collection of shell functions?
from bunsen-pipemenus.
"It would be more elegant, but is it worth the effort?"
Yes it would be better to have library functions, but since it doesn't affect anything atm is it worth the effort of re-writing scripts at this stage? It could be left for BL Deuterium (aka BL Hydrogen 1.1 )
from bunsen-pipemenus.
^true. There's plenty of stuff to sort out as it is.
from bunsen-pipemenus.
^ Agreed. So I suggest to keep things private that don't need to be public :D
from bunsen-pipemenus.
What do you mean by private? Just use another branch, perhaps?
from bunsen-pipemenus.
Not in a library but in the files. No library. Like functions declared static in C. A bit unlucky choice of words on my side.
from bunsen-pipemenus.
Related Issues (20)
- Package not found: Google chrome stable HOT 2
- "Recent Files" pipemenu nil value error and "Clear Recent Files" not working. HOT 9
- Edit to bl-tint2-pipemenu HOT 1
- bl-tint2-pipemenu when running default tint2 does not find config file to edit HOT 5
- ssh-pipemenu doesnt list the remote servers HOT 3
- Menu capitalization HOT 1
- Change some dependencies to recommends? HOT 8
- bl-multimedia-pipemenu: change labelling of smplayer as "Gnome mplayer" HOT 12
- bl-multimedia-pipemenu remove "volti" entry, do not add "volumeicon"? HOT 2
- bl-dropbox-pipemenu doesn't show progress of dependency installation HOT 7
- pipemenu's "Install" screen doesn't close HOT 8
- Scripts called from bunsen-utilities: test before adding menu item? HOT 1
- Remove package yad and packages bunsen-pipemenus and bunsen-untilities are removed too. HOT 2
- bl-kb-pipemenu can be speeded up HOT 1
- bl-compositor: needs to deal with '-h/--help' parameters HOT 20
- bl-recent-files-pipemenu: command truncated in some cases HOT 1
- bl-x-www-browser-pipemenu: select default browser should exit with a message... HOT 2
- bl-x-www-browser-pipemenu: there is no package called "firefox" in Debian Jessie HOT 2
- Having issues with bunsen pipemenus
- bl-recent-files-pipemenu: adapt script and package to use Lua 5.3 in Stretch HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bunsen-pipemenus.