Giter VIP home page Giter VIP logo

Comments (7)

Hjdskes avatar Hjdskes commented on June 22, 2024

Thanks for your contribution and my apologies for the delay in a response! This is now fixed in my fork. Pylint now reports:

W: 14, 0: TODO: (fixme)
W: 25, 0: FIXME: replace with an actual enum in python3 (fixme)
W:155, 0: TODO: might have to unmaximize_vert window first (fixme)
W:156, 0: FIXME from corenominal: adjust horizontal placement, not sure where this discrepancy comes from? (fixme)
W:181, 0: FIXME: replace with switch in python 3 (fixme)
W:194, 0: FIXME: geom.x and geom.y are always 10 and 34 (fixme)
C: 17, 0: Line too long (103/100) (line-too-long)
C:166, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:236, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:  1, 0: Invalid module name "bl-aerosnap" (invalid-name)
R: 26, 0: Too few public methods (0/2) (too-few-public-methods)
C: 83, 4: Invalid argument name "x" (invalid-name)
C: 83, 4: Invalid argument name "y" (invalid-name)
R: 83, 4: Too many arguments (7/5) (too-many-arguments)
W:144, 8: Using the global statement (global-statement)
W:145,18: Use of eval (eval-used)
C:210, 0: Missing function docstring (missing-docstring)
C:235, 0: Missing function docstring (missing-docstring)

...

Global evaluation
-----------------
Your code has been rated at 8.39/10 (previous run: 8.78/10, -0.39)

The -0.39 comes from a big TODO comment I just added to remind myself what needs to be done still.

from bunsen-utilities.

junkmechanic avatar junkmechanic commented on June 22, 2024

@Unia Looks great, your fork. Do you intend on merging your commit with this repo at some point or should i follow yours separately?

from bunsen-utilities.

Hjdskes avatar Hjdskes commented on June 22, 2024

I intend to make a PR when all issues are resolved :)

from bunsen-utilities.

johnraff avatar johnraff commented on June 22, 2024

@Hjdskes The code in the deuterium branch looks to me basically unchanged. Is your fork ready to merge?

from bunsen-utilities.

Hjdskes avatar Hjdskes commented on June 22, 2024

No, but I do not have time to continue development right now.

from bunsen-utilities.

johnraff avatar johnraff commented on June 22, 2024

OK no problem.

from bunsen-utilities.

johnraff avatar johnraff commented on June 22, 2024

For lack of interest, bl-aerosnap has been removed from bunsen-utilities.

from bunsen-utilities.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.