AttributeError: 'list' object has no attribute 'split' about python-readability HOT 5 CLOSED

I guess I might have removed sending lists to negative_keywords and positive_keywords -- only comma-separated string can be now used.
Please use them separated with comma as a workaround for a while, I'll fix it in the next version.

from python-readability.

Might be worth changing the examples too.

From:

            positive_keywords=["news-item", "block"]
            negative_keywords=["mysidebar", "related", "ads"]

To

            positive_keywords="news-item, block"
            negative_keywords= re.compile(r"mysidebar|related|ads")

https://github.com/buriy/python-readability/blob/master/readability/readability.py#L90

from python-readability.

Ah okay, it makes sense, thanks for this prompt feedback!

I do not mind changing the syntax but I'd do it only if the change in long-term. Otherwise I'd rather wait for the fix to be released.

As @olivierthereaux said, better to update the doc (README) and code comments if the change is long term, because we spent a bit of time yesterday, confused for the syntax not to work as documented.

from python-readability.

I think, I will allow all three options (comma-separated, list and regex) because it won't cost much -- it should only run once on Document initialization.

from python-readability.

👍 Whichever options are chosen, the docs should be right.

I couldn't figure out what the problem was because I was only looking at the docstring. As soon as I looked at the code, I realised the docstring is wrong: only regex or strings are allowed, not lists.

from python-readability.