Using git commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-ur

I cannot attach a one-line patch file, so here it is <div class="snippet-clipboard

Fixed in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https

No volume sliders appear if there is a non-ALSA sinks about volctl HOT 3 CLOSED

buzz commented on September 21, 2024

No volume sliders appear if there is a non-ALSA sinks

from volctl.

Comments (3)

ironss commented on September 21, 2024

I cannot attach a one-line patch file, so here it is

diff --git a/volctl/slider_win.py b/volctl/slider_win.py
index dfb360a..01f0ecd 100644
--- a/volctl/slider_win.py
+++ b/volctl/slider_win.py
@@ -137,6 +137,8 @@ class VolumeSliders(Gtk.Window):
                 sinks = []
                 sink_inputs = []
 
+            sinks = [ sink for sink in sinks if 'alsa.card_name' in sink.proplist ]
+

from volctl.

ironss commented on September 21, 2024

A better idea is to replace property 'alsa.card_name' with property 'device.description' is the ALSA card name does not exist. Then we do get a volume slider for both sink 'Simultaneous output...' and sink-input 'Simultaneous output...' -- I did not realise that these are two different things.

So, instead of the previous patch, try

diff --git a/volctl/slider_win.py b/volctl/slider_win.py
index dfb360a..ffde03e 100644
--- a/volctl/slider_win.py
+++ b/volctl/slider_win.py
@@ -139,8 +139,13 @@ class VolumeSliders(Gtk.Window):
 
         # Sinks
         for sink in sinks:
+            try:
+                card_name = sink.proplist["alsa.card_name"]
+            except KeyError:
+                card_name = sink.proplist["device.description"]
+
             props = (
-                sink.proplist["alsa.card_name"],
+                card_name,
                 "audio-card",
                 sink.volume.value_flat,
                 sink.mute,

and hope that 'device.description' is always available.

Edit: I see you do something similar (with nested exceptions) in function _name_icon_name_from_sink_input(), when trying to find the name and icon_name for a sink-input.

from volctl.

buzz commented on September 21, 2024

Fixed in 8cd4ef4

from volctl.

Recommend Projects