Giter VIP home page Giter VIP logo

Comments (12)

buzz avatar buzz commented on May 28, 2024

Yes, absolutely. The program should detect that I guess.
Do you bother to create a pull request?

from volctl.

Narrat avatar Narrat commented on May 28, 2024

I'm currently looking at the tray.py to find out if I can help with it

from volctl.

buzz avatar buzz commented on May 28, 2024

The placing is happening here:
https://github.com/buzz/volctl/blob/master/volctl/tray.py#L207

The question is how to decide if the sliders should show above or below the icon. You could query the screen dimensions and if the icon is in the top half of the screen sliders go below otherwise above.

This way the most common cases (top/bottom panels) would be covered, right?

from volctl.

Narrat avatar Narrat commented on May 28, 2024

At least the top/bottom panel users would be happy. Dunno about those, that place panels at the left or right.
Left would be less of an issue as with right placement, as the slider windows is appended to the right?

from volctl.

buzz avatar buzz commented on May 28, 2024

Yeah, they are probably more cases. Think of right-to-left script like Arabic.

But top/bottom panels would be awesome already ;)

from volctl.

Narrat avatar Narrat commented on May 28, 2024

Didn't work that much with PyGI before. Is there a simple way to define in which direction the popup will open or can the size of the whole thing be calculated nicely?
Currently stuck at that point.
Hardcoded position values won't do it, as the size depends on font settings, gtk theme and so on (which is the next issue on the list :D If enough pa applications open, the slider menu will expand beyond the screen)

from volctl.

Narrat avatar Narrat commented on May 28, 2024

Current WIP Narrat@709b146

Will take a look at the doc later. This magic value needs to vanish :D

from volctl.

Narrat avatar Narrat commented on May 28, 2024

Cannot use get_size for the window, because it will return a default value as the window isn't visible. So it's reporting back 200x200 which is way to much for a correction.

Actual height for me is 165px. Your screen shows 155px.
If I don't hardcode the value I can "calculate" a value of 172px. Still hardcoded value in there (guess of icon size (16px)). Acceptable for me but not for everyone else :D

from volctl.

buzz avatar buzz commented on May 28, 2024

You are right: The window height is only available after calling window.show().

Could you test this, please?
https://github.com/buzz/volctl/tree/issue_7

from volctl.

Narrat avatar Narrat commented on May 28, 2024

the issue_7 branch works for me :)

from volctl.

ScuttleSE avatar ScuttleSE commented on May 28, 2024

Reopening this.
I'm on a three monitor setup, and the slider-popups opens up almost in the middle of my middle monitor instead of on top of the tray icon, which is also on the middle screen.

My guess is that the program gets the resolution of my left or right monitor and uses that for the positioning instead of the middle one.

from volctl.

buzz avatar buzz commented on May 28, 2024

Reopening this.
I'm on a three monitor setup, and the slider-popups opens up almost in the middle of my middle monitor instead of on top of the tray icon, which is also on the middle screen.

My guess is that the program gets the resolution of my left or right monitor and uses that for the positioning instead of the middle one.

Opened #22 for this.

from volctl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.