Subtitles file validation about pysrt HOT 7 CLOSED

Hi,

Pysrt is not supposed to raise a ValueError like that. On that kind of parsing error it should raise a pysrt.InvalidItem.
It's a bug so I will fix it ASAP.

About the is_valid method: the only way to now if a SubRip file is properly formated is to parse it, so it will be just an alias of open that catch the exception and return Trueor False. I don't think that it's really useful. And it could be misleading because you can fail to parse a properly formatted file for an encoding reason.

from pysrt.

Anyway, if that raises a InvalidItemError that's ok for me :)

from pysrt.

It will in a few minutes.

from pysrt.

Both pysrt 0.4.2 and pysrt3 0.4.2have been released with the fix.

Note that in your case you should catch the base exception pysrt.Error https://github.com/byroot/pysrt/blob/master/pysrt/srtexc.py

from pysrt.

This is a partial solution because I still can't validate the structure of the file only and have to validate both the structure of the file and encoding.
I don't care about encoding so I'd like to be able to use this https://github.com/byroot/pysrt/blob/master/pysrt/srtfile.py#L267 :

source_file = codecs.open(path, 'rU', encoding=encoding, errors='replace')

For now, pysrt doesn't allow that.

from pysrt.

You can give any file like object to pysrt:

source_file = codecs.open(path, 'rU', encoding=encoding, errors='replace')
try:
  for item in pysrt.SubRipFile.stream(source_file, error_handling=SubRipFile.ERROR_RAISE):
    pass
except pysrt.Error:
  valid = False
else:
  valid = True

But allowing to specify errors='replace' is a good idea. I will surely add it to pysrt soon.

from pysrt.

Right, didn't thought of this option. Thanks

from pysrt.