File encoding guessing with charade (= chardet) about pysrt HOT 3 CLOSED

For now I stated that guessing the encoding belongs to the application that use pysrt.

But now that you talk about it, it's silly because we already detect encoding through BOMs in the library and we also depends of chardet because of the srt command.

So I think it's a good idea. If you want to fill a pull request tell me, otherwise I'll do it in a few days.

Le 2012-12-08 à 14:31, Antoine Bertin [email protected] a écrit :

This could be used on a failed attempt to open a file due to UnicodeDecodeError. charade would be called to detect the encoding and a second attempt to open the file would be done.
This would be the default behavior and suppressed if encoding argument is not None.

What do you think?

—
Reply to this email directly or view it on GitHub.

from pysrt.

I can't figure out why but the python3 version of charade have trouble to detect BOM files.

It return me different variations of ISO encodings for my tests files.
The bug is also present in chardet2

I should fill an issue ...

For now it delay the pysrt3 release.

from pysrt.

Everything is green now.

from pysrt.