Subtitles validation about pysrt HOT 4 OPEN

A convenience method in pysrt would be welcome to check for valid subtitles files.

from pysrt.

I'm not sure if pysrt should consider an empty text as an error.
All I can say right now is that it's not an intended behavior, in fact I never tough about that possibility.

I think it's reasonable to consider them as valid unless you know some players that fail to parse them ?

from pysrt.

I'm also ok to implement a kind of pysrt.validate(path, encoding=None), but i'm not sure of the best behavior:

• Should I just return a boolean or the error list ?
• If I fail to parse because of an encoding error should I raise or consider the file as invalid ?

Your feedback on this one is welcome.

from pysrt.

My personal taste is pysrt.is_valid(path, ignore_encoding_errors=True) that checks for subtitle file error. When having issues with encoding, most readers will just display unreadable characters but will read the file anyway hence the ignore_encoding_errors.
I think it's important to dissociate structure validation and encoding issues.

I wouldn't use the error list but I agree that could be useful for some.

from pysrt.