[BUG] `BindIP` option doesn't validate IP about silenttrinity HOT 6 OPEN

Thanks! Good catch, we should def be validating these

from silenttrinity.

I'd expect ST to validate that the BindIP given is one that can be bound.

Maybe not one that can be bound? Might affect people using any sort of proxy in front of ST and expect callbacks to that IP. But probably a good idea to at least make sure the IP is a valid IP.

from silenttrinity.

Didn't think of that! Yeah I'll def just add a check to make sure the IP is valid.

from silenttrinity.

I just had a weird moment of clarity. Maybe there should be a listener IP value and a callback IP value.

The listener should be something that can be bound to, since that's immediately exposed to ST.

The callback value doesn't have to be exposed to ST, and generating stagers should use the callback value if it's set. Otherwise, use the listener value.

..unless that's already what happens with CallbackUrls. I haven't tried that. 🤷🏾‍♂️

from silenttrinity.

I just had a weird moment of clarity. Maybe there should be a listener IP value and a callback IP value.

The listener should be something that can be bound to, since that's immediately exposed to ST.

The callback value doesn't have to be exposed to ST, and generating stagers should use the callback value if it's set. Otherwise, use the listener value.

..unless that's already what happens with CallbackUrls. I haven't tried that. 🤷🏾‍♂️

This is what CallbackURLs is for.

from silenttrinity.

I cannot reproduce this. Without supplying a valid BindIP the listener won't start (which makes sense).
It's easy enough to add validation to the inputs when being set...but I'm curious how you managed to start the listener without a valid address.

from silenttrinity.