Instantiation prevents graceful shutdown. about byu-jwt-nodejs HOT 6 CLOSED

It's not a pain point because of the workaround. If it can get on the roadmap for the future, then that'd be fine.

from byu-jwt-nodejs.

A found a work around by handling the SIGINT event and calling process.exit(0).

from byu-jwt-nodejs.

That's probably because of these lines:

  process.on('exit', () => shutdown('exit', data)) // app is closing
  process.on('SIGINT', () => shutdown('SIGINT', data)) // catches ctrl+c event
  process.on('SIGBREAK', () => shutdown('SIGBREAK', data)) // catches Windows ctrl+c event
  process.on('SIGUSR1', () => shutdown('SIGUSR1', data)) // catches "kill pid"
  process.on('SIGUSR2', () => shutdown('SIGUSR2', data)) // catches "kill pid"

I don't know the original motivation for doing things this way instead of exposing shutdown to users and expecting them to call it as needed.

If this behavior continues to be a pain point, we can change it in a future major release.

from byu-jwt-nodejs.

Add this line of code to your server file:

process.on('SIGINT', () => process.exit())

from byu-jwt-nodejs.

@GaryGSC Is there a problem exiting without clearing timeouts? I think we can remove those lines and expose a clearCache function instead of the shutdown function.

from byu-jwt-nodejs.

fixed in #89

from byu-jwt-nodejs.