Giter VIP home page Giter VIP logo

Comments (2)

jeffdupont avatar jeffdupont commented on August 16, 2024

I second this issue. Anything > 28 should fallback to the last day of the month.

from moment-recur.

jeffdupont avatar jeffdupont commented on August 16, 2024
            // match on end of month days
            if ( unitType === 'date' && unit == date.add(1, 'months').date(0).format('D') && unit < 31) {
                while ( unit <= 31 ) {
                    if ( list[unit] ) {
                        return true;
                    }
                    unit++;
                }
            }

I just kinda threw this together quickly, I added this to line 149 inside the matchCalendarRule function. This seems to work, but I'm not 100% sure that it covers all possibilities. It basically makes sure that the unitType is set to 'date' since that applies to daysOfMonth() and it checks if it's the last day of the month. It then loops through to check if the list has additional days after the end of the current month.

Hope this helps.

from moment-recur.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.