Comments (6)
@Garrett-R Just tested both and it's working!
from python-sitemap.
Interesting. I will test it tomorrow on my Mac.
from python-sitemap.
I'm getting this too on Linux. I notice it starts with an error about the set changing size during iteration:
INFO:root:Crawling #44: https://up.codes/s/bond-beams
INFO:root:Crawling #45: https://up.codes/s/transformer-efficiency
Traceback (most recent call last):
File "main.py", line 60, in <module>
crawl.run()
File "/home/garrett/_Garrett/upcodes_general/external_repos/python-sitemap-2/crawler.py", line 132, in run
event_loop.run_until_complete(self.crawl_all_pending_urls(executor))
File "/usr/lib/python3.7/asyncio/base_events.py", line 579, in run_until_complete
return future.result()
File "/home/garrett/_Garrett/upcodes_general/external_repos/python-sitemap-2/crawler.py", line 146, in crawl_all_pending_urls
for url in self.urls_to_crawl:
RuntimeError: Set changed size during iteration
ERROR:concurrent.futures:exception calling callback for <Future at 0x7fd202b34610 state=finished returned NoneType>
Traceback (most recent call last):
File "/usr/lib/python3.7/concurrent/futures/_base.py", line 324, in _invoke_callbacks
callback(self)
File "/usr/lib/python3.7/asyncio/futures.py", line 362, in _call_set_state
dest_loop.call_soon_threadsafe(_set_state, destination, source)
File "/usr/lib/python3.7/asyncio/base_events.py", line 728, in call_soon_threadsafe
self._check_closed()
File "/usr/lib/python3.7/asyncio/base_events.py", line 475, in _check_closed
raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed
This makes me think it might be solved by merging #63.
from python-sitemap.
Interesting. I can't reproduce it in linux. Do you experience it in every website or just on up.codes
?
from python-sitemap.
Yeah, actually not surprised since I only experienced once in ~10 runs (on up.codes
and running with --num-workers 8
, didn't test other sites). I noted in #63 that the race condition was unlikely to occur, which fits with my rate of seeing it. My theory is that for some reason, there's a higher chance of having hit it in Mac.
@dpatz do you mind trying to rerun with the latest master
now that the race condition is fixed to see whether this was the same bug or a different one? Perhaps try with -n 2
and also -n 8
to be sure.
from python-sitemap.
Nice to hear.
from python-sitemap.
Related Issues (20)
- No URLs found HOT 7
- Stop and continue HOT 1
- Handling more than 50,000 URLs HOT 4
- Add package to PyPI HOT 5
- Feature Request: Limit per category/section the number of URLs to parse
- AttributeError: 'NoneType' object has no attribute 'geturl' HOT 4
- Python 3.9.6 support? SyntaxError HOT 5
- Exclude canonicalized pages
- URL UnicodeEncodeError
- urls not saved to sitemap.xml HOT 2
- Windows and/or Python 3.7.2? HOT 2
- How to add hreflang tags HOT 2
- crawling depth setting
- Alphabetize URLs HOT 1
- How to exclude noindex page
- Option to specify bot for robots.txt HOT 2
- iframe contents ignored
- Client-side rendered SPAs don't work
- --parserobots doesn't seem to work
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-sitemap.