Warning(s) during compile: statement with no effect about h3 HOT 2 OPEN

Maybe just turn off the unused value warnings for now.

from h3.

The code in src/request_header.c:96 and src/request_header.c:126 is clearly wrong:

iscrlf( p ); p += 2;

executes an evaluation of a boolean expression iscrlf, does nothing and blindly increments the pointer.

I think this is correct:

if( iscrlf( p ) ) {
  p +=2;
} else {
  /* this is a parse error, expecting CR LF */
  return -1;
}

Disabling warnings is always bad in this situation.

Using macros doesn't make the code faster, just more unreadable. A function
iscrlf( char c ) would be my personal preference.

from h3.