Giter VIP home page Giter VIP logo

Comments (3)

huguesfcadets avatar huguesfcadets commented on June 12, 2024

(on behalf of @kirvanp )
As far as the back buttons being gone on the iPhone version, I have noticed this since iOS 13 came out. I suggest updating the target to iOS 13.4, as the iPads are capable of running that, and doing the recommended adjustments to the code. Upgrading the target will make Xcode more willing to give warnings for code that was meant for iOS 10-12 that might no longer work. It will also result in a smaller app size as iOS 13 has the Swift runtime built into the OS rather than included with the app.

from ets.

huguesfcadets avatar huguesfcadets commented on June 12, 2024

Setting target to iOS13

When changing target to iOS 13; 47 warning of deprecated things from iOS 12 and 13 are found. Nothing about traitCollectionDidChange (see below).
Changing the target to iOS 13 will be a new project with specific issues to resolve deprecated usage.

Findings about the issue.

Found that traitCollectionDidChange not called at the same moment when on iOS 10 vs when on iOS 13.
For example, when the addAircraftPopover is shown under iOS 13, traitCollectionDidChange is not called. But if you change the orientation of the device, it is called and the "Done" button appears.
The function addOrRemoveDonButtonGivenTraitCollection is called from 8 other places.

Proposed changes

Proposed changes, for contexts similar to the one in AddAircraftPopover, is to remove the need of addOrRemoveDoneButtonGivenTraitCollection by adding the button for the specific trait.

from ets.

kirvanp avatar kirvanp commented on June 12, 2024

from ets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.