Comments (3)
(on behalf of @kirvanp )
As far as the back buttons being gone on the iPhone version, I have noticed this since iOS 13 came out. I suggest updating the target to iOS 13.4, as the iPads are capable of running that, and doing the recommended adjustments to the code. Upgrading the target will make Xcode more willing to give warnings for code that was meant for iOS 10-12 that might no longer work. It will also result in a smaller app size as iOS 13 has the Swift runtime built into the OS rather than included with the app.
from ets.
Setting target to iOS13
When changing target to iOS 13; 47 warning of deprecated things from iOS 12 and 13 are found. Nothing about traitCollectionDidChange (see below).
Changing the target to iOS 13 will be a new project with specific issues to resolve deprecated usage.
Findings about the issue.
Found that traitCollectionDidChange not called at the same moment when on iOS 10 vs when on iOS 13.
For example, when the addAircraftPopover is shown under iOS 13, traitCollectionDidChange is not called. But if you change the orientation of the device, it is called and the "Done" button appears.
The function addOrRemoveDonButtonGivenTraitCollection is called from 8 other places.
Proposed changes
Proposed changes, for contexts similar to the one in AddAircraftPopover, is to remove the need of addOrRemoveDoneButtonGivenTraitCollection by adding the button for the specific trait.
from ets.
from ets.
Related Issues (20)
- ITMS-90683: Missing Purpose String in Info.plist HOT 1
- Crashes when Sign in Flight (under Pilot Options) is initiated. HOT 1
- Bluetooth usage HOT 1
- Create contribution rules HOT 3
- App crashes accessing photo album without usage description
- Upgrade ETS for iOS 13
- Buggy Date / Time Pickers in iOS 14 HOT 2
- Syncing Reliability Issues / iOS 14 Support HOT 2
- Done button does not show in the Add pilot screen HOT 3
- TTSN, TNI and TTNI window are unreadable on iPhone in light mode
- Show Archived Pilots filter (in Add Pilot screen) unreadable in dark mode on iPhone
- Usability issue with Date picker HOT 1
- Labels in Add cadet screen not visible
- Various report outputs only showing the EXCEL attachments, PDF version has disappeared. HOT 1
- Default email addresses in settings not populating in report email box when generated
- The application crashes when exporting the database HOT 1
- Mailing report from the app does not get the email sent HOT 1
- Designated Flight Authorization Officer
- Crash when attempting to open on a M2 Macbook Pro
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ets.