caiogondim / blooming-menu.js Goto Github PK

I like the project, but, for many of us, an example showing an actual click function working for the blooming buttons would be helpful since just having the blooming menu with no function for the buttons makes it not easily usable in a project.

Calling removeEventListener with one parameter raises an exception in Chrome (but not Safari).

The following code raises a TypeError in Chrome but nothing in Safari:

document.querySelector('body').removeEventListener('foo')

It seems that the calls to removeEventListener required a named function, otherwise they throw an error. This occurs in the selectItem call:

    var btnWrappers = document.querySelector('.' + self.props.CSSClassPrefix + ITEM_BTN_WRAPPER_CSS_CLASS)
    btnWrappers.addEventListener(animationEndEventName(), function () {
      self.close()

      self.props.elements.items.forEach(function (item) {
        item.style.display = 'none'
      })

      document
        .querySelector('.' + self.props.CSSClassPrefix + ITEM_BTN_WRAPPER_CSS_CLASS)
        .removeEventListener(animationEndEventName()) // <-- Requires 2 params
    })

There are calls to removeEventListener via instance.remove() too:

  function unbindEventListeners (self) {
    self.props.elements.main.removeEventListener('click')
    self.props.elements.main.removeEventListener('touchstart')
  }

These also throw errors in Chrome. This can be reproduced simply with:

var menu;
menu = new BloomingMenu({ itemsNum: 3 });
menu.render();
menu.remove();

I can work on a PR for this but just want to make sure I'm not missing something obvious about how the library or removeEventListener works.