Giter VIP home page Giter VIP logo

Comments (7)

othercorey avatar othercorey commented on May 27, 2024 1

The concept of apply scope make sense. I'm not sure if we can make scope, action, operation consistent in all places.

I'm dropping the action name change.

from authorization.

othercorey avatar othercorey commented on May 27, 2024

I should point out that I'm suggesting a config format change to combine the various action-specific configs into a single action => [config] format. This will avoid the need for confusing functions.

from authorization.

ADmad avatar ADmad commented on May 27, 2024

👍 for AuthorizationComponent::authorize() => AuthorizationComponent::access(), not sure about replacing the other methods with setConfig(). I haven't used the component enough to have an informed opinion on it.

from authorization.

othercorey avatar othercorey commented on May 27, 2024

👍 for AuthorizationComponent::authorize() => AuthorizationComponent::access(), not sure about replacing the other methods with setConfig(). I haven't used the component enough to have an informed opinion on it.

The reason for the change is authorizeModel() doesn't make sense especially now. I could replace it with another name, but seemed awkward.

It's an alternative for discussion.

from authorization.

markstory avatar markstory commented on May 27, 2024

We already use the term scope in Authorization to mean the type of access requested for a resource. It make sense to use it consistently.

Using scope to mean two different things in this plugin is a bit concerning to me. Could access() use operation instead?

from authorization.

othercorey avatar othercorey commented on May 27, 2024

Using scope to mean two different things in this plugin is a bit concerning to me. Could access() use operation instead?

I also want a consistent word for the "type of access" being requested for anything. It's currently "action", and I think that's confusing. I was going to suggest scope since we have applyScope ... but maybe that name needs to be adjusted as well since apply doesn't make sense.

from authorization.

markstory avatar markstory commented on May 27, 2024

The idea behind apply was that those methods mutate a query or selection so that access controls have been 'applied'.

from authorization.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.