Giter VIP home page Giter VIP logo

Comments (4)

benschwarz avatar benschwarz commented on May 17, 2024 3

@lfgcampos Thanks for logging this. This isn't something I've personally encountered, but I can see how some changes would improve things.

We could add a simple markdown template as you've suggested, but I think I'd prefer to limit the output of the existing templates so that up to 50 images are posted to a markdown table. If there's more images than 50, the table could be omitted.

Perhaps the output could be along the lines of:

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by <%- overallPercentageSaved %>%, saving <%- overallBytesSaved %>.

<% if(optimisedImages.length < 50) { -%> <!-- table of compression summary, limited to 50 images --><% } %>

<% if(unoptimisedImages.length) { -%> <%- unoptimisedImages.length %> <%- unoptimisedImages.length > 1 ? 'images' : 'image' %> did not require optimisation. <% } %>

What do you think @lfgcampos? Would that cover your use case?

Would you be in a position to help action this change?

from image-actions.

lfgcampos avatar lfgcampos commented on May 17, 2024

Thanks for the quick reply @benschwarz!
Sounds good to me!

Another small thing I would add would be the number of optimized images in case the table is not shown.
At least we would know how many were optimized and how many wasn't.

Sure, I can try to work on this change as it looks trivial!

from image-actions.

lfgcampos avatar lfgcampos commented on May 17, 2024

PR is opened!

from image-actions.

lfgcampos avatar lfgcampos commented on May 17, 2024

Hi @benschwarz, sorry to bother you but any chance to look at the PR?

from image-actions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.