Issues with type 2 occurring more than once about callbag HOT 3 CLOSED

Adding a flag to break the while loop solved it (fromIter):

  function loop() {
    inloop = true;
    while (got1) {
      if (finished) break;
      got1 = false;
      res = iterator.next();
      if (res.done) {
        sink(2);
        finished = true;
      } else sink(1, res.value);
    }
    inloop = false;
  }

from callbag.

I'm not sure, but I believe the problem is in the done function:

} else if (type === 2) {
  operation();
  sink(type, data);
}

Try adding the sink(type, data) after the call to operation() and try again. You are not letting the sink know that the source finished, so the sink is talking back, asking for data.

EDIT: no that's not the problem, although you should definitely let the sink know about type: 2.
The problem is that when you start emitting what you stored in the array the sink talks back 1. You emit the last element of the array, the talkback asks for more data and the fromIter() sends 2 downwards again. That's why you're getting done() twice.
I'm not sure how to fix this, though.
It's a problem in the fromIter I guess, @staltz
Perhaps a flag "finished" is necessary to prevent the loop again.

from callbag.

Thanks! Can anyone think of a test case for callbag-from-iter?

from callbag.