Comments (6)
would you mind digging into this a bit further for me? I think the spike may be caused by requestAnimationFrame
being called 60 times per second, to achieve a 60fps scroll. The scroll completing would explain the "cliff". In that case, I wouldn't think it's a memory leak. I know the Chrome dev tools allow you to dig into the JS stack and see what function(s) are being called, perhaps your tools provide a similar feature?
will leave this open until I hear back, thank you
from jump.js.
It could be as you say - I just went to your test site... hit record, pressed the go down button, pressed to go up button.
I havn't had chance to dig into it yet though, could it be creating variables every time rAF calls?
from jump.js.
the _loop
function is what runs within each requestAnimationFrame
call. that code is highlighted here: https://github.com/callmecavs/jump.js/blob/master/src/jump.js#L18-L31
it's only referencing and working with existing class properties - all that is created is more requestAnimationFrame
s. therefore, I don't think this is related to creating variables. there is some math related to the easing function that happens in each loop, but I couldn't imagine those low level operations would cause this type of spike.
if you get a chance, i'd really appreciate you doing some more digging 🙌
from jump.js.
did some profiling in the Chrome dev tools, and I'm not seeing anything out of the ordinary. going to close this for now, as I believe what you're seeing is related to the requestAnimationFrame
calls. if in your futher testing you come across something in particular, I'll reopen it and take a peak. thanks again for your efforts
from jump.js.
here are some screenshots of the heap from the Chrome devtools as well:
seems as though everything from the lib is insignificantly small
from jump.js.
looping in @jaxgeller, as he helped with some of this profiling
from jump.js.
Related Issues (20)
- Function not found due to wrong path HOT 8
- No module export HOT 3
- It is a nightmare to use this with my angular 2 application using system js for bundling HOT 1
- Sometimes callback executing before scrolling has finished HOT 1
- prevent calling jump() when current jump is not finished
- Is it possible to use Jump to replace the default behavior for the anchors? HOT 1
- Feature Request: Make target optional HOT 1
- Document why tabindex is necessary when a11y: true HOT 4
- Option to prevent anchor from beeing added to the URL? HOT 1
- Error in case of jumping to non-existing target HOT 1
- Bug in Chrome With Small Viewports -- Jump Effect with Flicker and Ignoring Offset HOT 2
- Scrolling Breaks When CSS Has Overflow. HOT 1
- Prevent jumping when position is the same
- MIT Licence not assigned on GH HOT 1
- Can we use GSAP Easings with Jump.js ? HOT 2
- Doesn't work with gulp? HOT 1
- Help needed with angular
- An old scholl version, really.. HOT 2
- Can't scroll back up the page
- Lazy loading images
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jump.js.