Comments (8)
@ShaswatPrabhat Thanks for working on this. I'm not sure I understand your question though.
The data flow between the packages should be the same as is now for branch and commit-hash CLI options. The difference should be that when Reassure 'measure' command does not receive either branch or commit-hash option then it tries to get the missing value(s) from Git if possible.
from reassure.
A good place for checking these values is the very beginning of "run" method in measure.ts in CLI package
from reassure.
Resolved by #211
from reassure.
Picking this up please.
Will it be a good idea to keep these values as default in measure.ts
after auto detecting git
based branches ?
from reassure.
@mdjastrzebski there were a couple of things I wanted to check:
- Which way of spawning a child process would be preferable ? Right now I am looking at
child_process.fork
, but any notes regarding the same? - With the above approach the function becomes an IIFE like so:
const simpleGit = require('simple-git');
const git = simpleGit({ baseDir: process.cwd() });
const branch = await git.revparse(['--abbrev-ref', 'HEAD']);
const commitHash = await git.revparse(['HEAD']);
process.send({ branch, commitHash });
})();
Please let me know if this is what you had thought of
from reassure.
I've looked more into the simple-git
package. It seems that it's actually invoking git
binary by itself, so we can give it a try.
from reassure.
This is how it is shaping up @mdjastrzebski .
Not very happy with the IIFE .
Can we not have a simple await based function call immediately in run() method ? Do we need a fork at all
from reassure.
And an alternative way
from reassure.
Related Issues (20)
- [BUG] `TEST_RUNNER_ARG='--silent'` env var causes tests to be skipped HOT 2
- [FEATURE] Capture measurement date and time in metadata
- provide danger.js file in the examples HOT 2
- refactor: rename `examples/native` as
- RFC: move examples to separate repo HOT 1
- Query : Not able to render the page for reassure test with MockedProvider HOT 2
- [BUG] yarn reassure not working HOT 3
- [BUG] Installing Reassure fails other React native integration tests which uses MockProvider HOT 4
- [BUG] Error running yarn reassure - Object.defineProperty called on non-object HOT 2
- Discussion: Reassure v1.0 HOT 3
- [FEATURE] Support Running With Vitest Instead of Jest HOT 22
- [FEATURE] Support for NextJS setups not using Babel. HOT 2
- [BUG] Node's fetch fails because of the `--jitless` flag HOT 3
- [FEATURE] Measuring items of a list HOT 3
- Feature or Improvement Plans HOT 3
- [BUG] Module '"reassure"' has no exported member 'measureRenders' HOT 4
- [FEATURE] Improve `scenario` type def and export `MeasureOptions` from `reassure` HOT 3
- [Improvement] The suggested CI script should only reinstall dependencies if they changed between baseline branch and target branch HOT 1
- [Improvement] replace the unmaintained markdown-builder package HOT 2
- [FEATURE] Bun support HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reassure.