Page redirect protection about cbc-kitten-scientists HOT 5 CLOSED

I am not sure what we have to protect against this..
On May 17, 2015 1:36 PM, "Cameron Condry" [email protected] wrote:

I would like to see a notification pop up warning a user if a link is
going to load in the same window. The main reason for this is the interface
links will option in the same tab in most cases and will cause the user to
need to reload the script and game.

—
Reply to this email directly or view it on GitHub
#52.

from cbc-kitten-scientists.

After thinking about it a bit, the real issue is just the reddit/wiki links that don't open in new tabs. It may be a simple enhancement to just add target="_blank" to any external links in the system.

from cbc-kitten-scientists.

Sounds reasonable
On May 17, 2015 6:16 PM, "Cameron Condry" [email protected] wrote:

After thinking about it a bit, the real issue is just the reddit/wiki
links that don't open in new tabs. It may be a simple enhancement to just
add target="_blank" to any external links in the system.

—
Reply to this email directly or view it on GitHub
#52 (comment)
.

from cbc-kitten-scientists.

Is this still an issue? $("a[target!='_blank']").not("a[href$='#']") returns an empty array. So either all external links target _blank or my selector is off ;D

from cbc-kitten-scientists.

@cameroncondry This seems to no longer be an issue. Would you mind closing it?

from cbc-kitten-scientists.