Giter VIP home page Giter VIP logo

Comments (4)

peaBerberian avatar peaBerberian commented on June 3, 2024

Hi @eduter,

From what I understand, the "caption" track should normally have its closedCaption attribute set to true.
Better detecting closed caption is part of the future v3.30.0 that we're currently testing.

Can you check with the pre-release [email protected]? It is the last iteration of the release we're testing.

from rx-player.

eduter avatar eduter commented on June 3, 2024

The new isCaptioning function from v3.30.0 solves our problem πŸ‘
https://github.com/canalplus/rx-player/blob/release/v3.30.0-dev.2023022200/src/parsers/manifest/dash/common/parse_adaptation_sets.ts#L115

Is the decision to not expose role to make ITextTrack manifest format agnostic?

from rx-player.

peaBerberian avatar peaBerberian commented on June 3, 2024

Is the decision to not expose role to make ITextTrack manifest format agnostic?

That was the main idea yes. Also to simplify the API by pre-parsing the meaning of those attributes (for example captioning can be indicated through several ways even in DASH)

from rx-player.

peaBerberian avatar peaBerberian commented on June 3, 2024

The v3.30.0 is now officially released! You should have correct caption detection now.

I'm closing this issue, do not hesitate to re-open it if you still have a problem

from rx-player.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.