Giter VIP home page Giter VIP logo

Comments (10)

gtokman avatar gtokman commented on June 1, 2024 4

@nickvgn thanks for filing this, I'll see if I can get it fixed later this week!

from faster-image.

gtokman avatar gtokman commented on June 1, 2024 4

In the repo example, you demonstrate circular images....if the Platform is android

style.image is borderRadius: (size - 16) / 2

and the RCTView prop is borderRadius: size * 2

is there a reason that conventional radius calculations of CSS can't be used consistently? it's cumbersome to remember to come up with and use different calculations, especially based on Platform.

It's because Android has some complexity when round corners. I'm keeping this issue open & will make it consistent next PR.

from faster-image.

gtokman avatar gtokman commented on June 1, 2024 2

@nickvgn resizeMode is fixed in the latest version!

from faster-image.

arnekolja avatar arnekolja commented on June 1, 2024

Setting overflow: 'hidden' in styles worked for me.

from faster-image.

arnekolja avatar arnekolja commented on June 1, 2024

+1 for resize mode not working. Makes this one useless for me for now, sadly :-(

from faster-image.

jamesholcomb avatar jamesholcomb commented on June 1, 2024

In the repo example, you demonstrate circular images....if the Platform is android

style.image is borderRadius: (size - 16) / 2

and the RCTView prop is borderRadius: size * 2

is there a reason that conventional radius calculations of CSS can't be used consistently? it's cumbersome to remember to come up with and use different calculations, especially based on Platform.

from faster-image.

nickvgn avatar nickvgn commented on June 1, 2024

thank you!

from faster-image.

efstathiosntonas avatar efstathiosntonas commented on June 1, 2024

i think the simple solution would be to apply overflow:hidden on the image styles or the container styles (or both)

from faster-image.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.